Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37485

admin/plugins.php does require_capability before require_login

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.7, 2.3.4, 2.4, 2.5
    • Fix Version/s: 2.2.8, 2.3.5, 2.4.2
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      1. Make sure you are not logged in.
      2. Go directly to the .../admin/plugin.php URL.
      3. Make sure you are redirected to the login page, rather than being shown an error message.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Leading to ugly errors if you are not logged in.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            This is not really a security issue, since it cannot be used to hack your site, so I did not restrict it. Still, there are security aspects, which is why I made the _22 branch.

            Show
            timhunt Tim Hunt added a comment - This is not really a security issue, since it cannot be used to hack your site, so I did not restrict it. Still, there are security aspects, which is why I made the _22 branch.
            Hide
            mudrd8mz David Mudrák added a comment -

            +1 thanks for spotting and fixing this Tim.

            Show
            mudrd8mz David Mudrák added a comment - +1 thanks for spotting and fixing this Tim.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (22, 23, 24 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (22, 23, 24 & master), thanks!
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested on the 2.2, 2.3, 2.4 and master integration branches. All branches redirected to the login page.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - Tested on the 2.2, 2.3, 2.4 and master integration branches. All branches redirected to the login page. Test passed.
            Hide
            poltawski Dan Poltawski added a comment -

            Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

            Show
            poltawski Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/13