Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.7, 2.3.4, 2.4, 2.5
-
Component/s: Administration
-
Labels:
-
Testing Instructions:
- Make sure you are not logged in.
- Go directly to the .../admin/plugin.php URL.
- Make sure you are redirected to the login page, rather than being shown an error message.
-
Affected Branches:MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
-
Fixed Branches:MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
-
Pull from Repository:
-
Pull 2.4 Branch:
MDL-37485_24 -
Pull 2.4 Diff URL:
-
Pull Master Branch:
-
Pull Master Diff URL:
-
Rank:47125
Description
Leading to ugly errors if you are not logged in.
Activity
+1 thanks for spotting and fixing this Tim.
Show
David Mudrak
added a comment - +1 thanks for spotting and fixing this Tim.
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
Show
Eloy Lafuente (stronk7)
added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
Integrated (22, 23, 24 & master), thanks!
Show
Eloy Lafuente (stronk7)
added a comment - Integrated (22, 23, 24 & master), thanks!
Tested on the 2.2, 2.3, 2.4 and master integration branches. All branches redirected to the login page.
Test passed.
Show
Adrian Greeve
added a comment - Tested on the 2.2, 2.3, 2.4 and master integration branches. All branches redirected to the login page.
Test passed.
Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!
Show
Dan Poltawski
added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!
This is not really a security issue, since it cannot be used to hack your site, so I did not restrict it. Still, there are security aspects, which is why I made the _22 branch.