Moodle
  1. Moodle
  2. MDL-37494

Group assignments ignore or duplicate group and grouping settings

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.4.1
    • Fix Version/s: None
    • Component/s: Assignment
    • Labels:
    • Affected Branches:
      MOODLE_24_STABLE

      Description

      Group assignments can be set up even if the assignment is not in group mode or a grouping is not selected in common module settings.

      Depending on one's viewpoint this means the common functionality is either ignored or duplicated.

      The current state of the module creates an unwelcome conflict as there appear to be two sets of settings that so the same thing but behave differently (e.g. no groupings indicator on the course page) with multiple interfaces.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Mary Cooch added a comment -

            If the assignment is not in group mode then it seems every student on the course is put into the default group for the assignment. Just for reference, adding a link to forum post I made after trying to get my head around group assignments/groups and groupings. I still feel it is a complicated set up to understand. https://moodle.org/mod/forum/discuss.php?d=216399#p942913

            Show
            Mary Cooch added a comment - If the assignment is not in group mode then it seems every student on the course is put into the default group for the assignment. Just for reference, adding a link to forum post I made after trying to get my head around group assignments/groups and groupings. I still feel it is a complicated set up to understand. https://moodle.org/mod/forum/discuss.php?d=216399#p942913
            Hide
            Ray Lawrence added a comment -

            Hi Mary,

            Agreed, but that's not the point I was trying to make.

            Group assignments can be set up even though the assignment activity is not set to separate or visible groups. So an assignment that shows No groups in Common module settings can also be set for group assignment submissions. A similar state of affairs now exists for groupings too.

            This mish-mash of settings has only just hit me.

            This (sort of) duplication doesn't help teachers who have learned how Groups and Groupings work and then have to take on an exception in this module. Behaviour should be consistent throughout IMO.

            Looking forward to Damyon's comments...

            Show
            Ray Lawrence added a comment - Hi Mary, Agreed, but that's not the point I was trying to make. Group assignments can be set up even though the assignment activity is not set to separate or visible groups. So an assignment that shows No groups in Common module settings can also be set for group assignment submissions. A similar state of affairs now exists for groupings too. This mish-mash of settings has only just hit me. This (sort of) duplication doesn't help teachers who have learned how Groups and Groupings work and then have to take on an exception in this module. Behaviour should be consistent throughout IMO. Looking forward to Damyon's comments...
            Hide
            Damyon Wiese added a comment -

            There are 2 different things that groups / groupings are used for in the assignment (this is why there are 2 groupings that can be set).

            The first is it can be setup so that teachers can only mark students in their group (course module group settings). This is the old behaviour and was the first to claim the course module group/groupings settings.

            When adding support for student groups - I had to add new settings so that upgraded assignments did not automatically become "group" assignments. I couldn't use the standard group/grouping settings because they already had a meaning and it would be confusing for existing users to change what they did.

            Show
            Damyon Wiese added a comment - There are 2 different things that groups / groupings are used for in the assignment (this is why there are 2 groupings that can be set). The first is it can be setup so that teachers can only mark students in their group (course module group settings). This is the old behaviour and was the first to claim the course module group/groupings settings. When adding support for student groups - I had to add new settings so that upgraded assignments did not automatically become "group" assignments. I couldn't use the standard group/grouping settings because they already had a meaning and it would be confusing for existing users to change what they did.
            Hide
            Ray Lawrence added a comment -

            Thanks. Out of office a bit this week, will look at this again when I have a moment.

            Show
            Ray Lawrence added a comment - Thanks. Out of office a bit this week, will look at this again when I have a moment.
            Hide
            Damyon Wiese added a comment -

            This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

            For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            Show
            Damyon Wiese added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
            Hide
            Paul A. Vitagliano added a comment -

            This is how this should be set up

            Show
            Paul A. Vitagliano added a comment - This is how this should be set up
            Hide
            Paul A. Vitagliano added a comment -

            This really has to be looked at again. Adding this duplication is really causing a lot of confusion with my faculty.

            What a train wreck.

            Show
            Paul A. Vitagliano added a comment - This really has to be looked at again. Adding this duplication is really causing a lot of confusion with my faculty. What a train wreck.
            Hide
            Hugo Ribeiro added a comment -

            I think this is extremely serious! This means that if a teacher wrongly activate "Submit in groups", all the course participants will have as a submission the first assignment submitted!
            This cannot be a minor bug!

            Show
            Hugo Ribeiro added a comment - I think this is extremely serious! This means that if a teacher wrongly activate "Submit in groups", all the course participants will have as a submission the first assignment submitted! This cannot be a minor bug!
            Hide
            Martin Dougiamas added a comment -

            I just tried this in 2.7 and I got an error when the first student tries to submit:

            Can not find data record in database table groups.
             
             Debug info: SELECT * FROM {groups} WHERE id = ?
             [array (
              0 => '0',
             )]
             Error code: invalidrecord
            

            Show
            Martin Dougiamas added a comment - I just tried this in 2.7 and I got an error when the first student tries to submit: Can not find data record in database table groups.   Debug info: SELECT * FROM {groups} WHERE id = ? [array ( 0 => '0', )] Error code: invalidrecord
            Hide
            Paul A. Vitagliano added a comment -

            This "serious" issue is how old now?

            Show
            Paul A. Vitagliano added a comment - This "serious" issue is how old now?
            Hide
            Damyon Wiese added a comment -

            I'll double check that bug you found later - this issue is more about the fact that we need 2 sets of group settings in mod_assign - I asked for some feedback about this at the last moodlemoot and was told to defintely not remove either one - so I guess we should leave it.

            Show
            Damyon Wiese added a comment - I'll double check that bug you found later - this issue is more about the fact that we need 2 sets of group settings in mod_assign - I asked for some feedback about this at the last moodlemoot and was told to defintely not remove either one - so I guess we should leave it.
            Hide
            Damyon Wiese added a comment -

            Martins error above looks like MDL-46485 which was fixed recently.

            Show
            Damyon Wiese added a comment - Martins error above looks like MDL-46485 which was fixed recently.
            Hide
            Paul A. Vitagliano added a comment -

            So where do we stand with this issue?

            Show
            Paul A. Vitagliano added a comment - So where do we stand with this issue?

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated: