Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37518

Need documentation to explain the introduction of the myaddinstance capability for blocks.

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1, 2.5
    • Fix Version/s: 2.4.2
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      This is a REALLY difficult test, sorry for anyone who has to test this. May take up to 2 days to finish.

      1. Open blocks/upgrade.txt and ensure text explaining the introduction of the myaddinstance capability is present.
      Show
      This is a REALLY difficult test, sorry for anyone who has to test this. May take up to 2 days to finish. Open blocks/upgrade.txt and ensure text explaining the introduction of the myaddinstance capability is present.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-37518_master

      Description

      There should be a description regarding issue MDL-34270 in the file blocks/upgrade.txt

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Upgraded the priorty, if we can get this integrated ASAP.

              Show
              poltawski Dan Poltawski added a comment - Upgraded the priorty, if we can get this integrated ASAP.
              Hide
              phalacee Jason Fowler added a comment -

              [Y] Syntax
              [-] Output
              [Y] Whitespace
              [-] Language
              [-] Databases
              [-] Testing
              [-] Security
              [Y] Documentation
              [Y] Git
              [Y] Sanity check

              All good Mark.

              Show
              phalacee Jason Fowler added a comment - [Y] Syntax [-] Output [Y] Whitespace [-] Language [-] Databases [-] Testing [-] Security [Y] Documentation [Y] Git [Y] Sanity check All good Mark.
              Hide
              phalacee Jason Fowler added a comment -

              Actually, looking at it again, not sure the asterisk is needed, as it's not a list. Just a thought.

              Show
              phalacee Jason Fowler added a comment - Actually, looking at it again, not sure the asterisk is needed, as it's not a list. Just a thought.
              Hide
              markn Mark Nelson added a comment - - edited

              Thanks Jason, got rid of that. I also added "'" around the capability name. Submitting for integration.

              Show
              markn Mark Nelson added a comment - - edited Thanks Jason, got rid of that. I also added "'" around the capability name. Submitting for integration.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated (24 & master), thanks!

              Silly question: Didn't we recently changed which blocks were allowed in the my page? When we did that... did we remove the "myaddinstance" caps from them? Note the documentation says that the cap is only for blocks not initially allowed.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (24 & master), thanks! Silly question: Didn't we recently changed which blocks were allowed in the my page? When we did that... did we remove the "myaddinstance" caps from them? Note the documentation says that the cap is only for blocks not initially allowed.
              Hide
              markn Mark Nelson added a comment -

              Hi Eloy, yes we did get rid of the myaddinstance capability. Only blocks that can be added on that page have this capability.

              Show
              markn Mark Nelson added a comment - Hi Eloy, yes we did get rid of the myaddinstance capability. Only blocks that can be added on that page have this capability.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Aha, perfect, thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Aha, perfect, thanks!
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Phewwww.... finally finished testing this issue.

              This looks great. Thanks Mark.

              Test passed.

              Show
              rwijaya Rossiani Wijaya added a comment - Phewwww.... finally finished testing this issue. This looks great. Thanks Mark. Test passed.
              Hide
              damyon Damyon Wiese added a comment -

              Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone!

              Regards, Damyon

              Show
              damyon Damyon Wiese added a comment - Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone! Regards, Damyon

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13