Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37521

Move (or add) "Reseting role button" on the define/edit role page

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.1.10, 2.2.5, 2.2.6, 2.2.7, 2.3.2, 2.3.3, 2.3.4, 2.4, 2.4.1
    • Fix Version/s: DEV backlog
    • Component/s: Roles / Access
    • Labels:
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE

      Description

      As i said in https://moodle.org/mod/forum/discuss.php?d=219730 i think that "Reseting role button" should better be on editing role page (than viewing role page), that seems a more logical place.

      Could you please add this button there (or move it from view role page) ?

      I think it's just a small change in admin/roles/define.php

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            tsala Helen Foster added a comment -

            Séverin, thanks for your report.

            Looking at the page /define.php?action=view I wonder whether we need it at all if the 'Reset to defaults' button is moved to define.php?action=edit? The only other thing you can do on the view role definition page is to duplicate the role, which you can also do on the manage roles page.

            Thus I think we should do as Séverin suggests and move the 'Reset to defaults' button to the edit role page and then delete the view role definition page.

            Show
            tsala Helen Foster added a comment - Séverin, thanks for your report. Looking at the page /define.php?action=view I wonder whether we need it at all if the 'Reset to defaults' button is moved to define.php?action=edit? The only other thing you can do on the view role definition page is to duplicate the role, which you can also do on the manage roles page. Thus I think we should do as Séverin suggests and move the 'Reset to defaults' button to the edit role page and then delete the view role definition page.
            Hide
            skodak Petr Skoda added a comment - - edited

            Hello, I am working on a redesign of role management UI, hopefully I will post some screenshots and mockups for general discussion later this week. Role reset is already part of that. Thanks for the report.

            Show
            skodak Petr Skoda added a comment - - edited Hello, I am working on a redesign of role management UI, hopefully I will post some screenshots and mockups for general discussion later this week. Role reset is already part of that. Thanks for the report.
            Hide
            fox Séverin Terrier added a comment -

            Nice to see i'm not the only one to think that, and also that Petr is already working on it!
            I think puting all action buttons on the edit page is a good thing, but it can be useful to have the view screen, just to view (and verify) with no risk to modify anything (comparing several roles would be useful).

            Show
            fox Séverin Terrier added a comment - Nice to see i'm not the only one to think that, and also that Petr is already working on it! I think puting all action buttons on the edit page is a good thing, but it can be useful to have the view screen, just to view (and verify) with no risk to modify anything (comparing several roles would be useful).
            Hide
            skodak Petr Skoda added a comment -

            In case of reset it should be also possible to select the way it does the reset - nothing, archetype, other role, xml definition, then admin should have a clear indication what was changed before hitting the save button.

            I personally think there should be fewer icons on the role list page - how often do you need them? Most of the times you review role first and then edit, right? Technically it is possible to have the icon that leads to reset form anywhere, let's see what others think about that. My +1 to have the reset button on role view and edit pages only.

            Moodle is not designed to deal with hundreds of roles, I suppose reasonable number of roles is < 20.

            Show
            skodak Petr Skoda added a comment - In case of reset it should be also possible to select the way it does the reset - nothing, archetype, other role, xml definition, then admin should have a clear indication what was changed before hitting the save button. I personally think there should be fewer icons on the role list page - how often do you need them? Most of the times you review role first and then edit, right? Technically it is possible to have the icon that leads to reset form anywhere, let's see what others think about that. My +1 to have the reset button on role view and edit pages only. Moodle is not designed to deal with hundreds of roles, I suppose reasonable number of roles is < 20.
            Hide
            skodak Petr Skoda added a comment -

            Thanks for the report. I suppose the linked issue could be used for discussion of all related role edit UI improvements.

            Show
            skodak Petr Skoda added a comment - Thanks for the report. I suppose the linked issue could be used for discussion of all related role edit UI improvements.
            Hide
            skodak Petr Skoda added a comment -

            I have finished working on MDL-17081, I would personally vote for keeping the current location of role reset button and instead remove the edit button from the list of roles.

            Show
            skodak Petr Skoda added a comment - I have finished working on MDL-17081 , I would personally vote for keeping the current location of role reset button and instead remove the edit button from the list of roles.

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: