Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.3.4, 2.4.1, 2.5
-
Component/s: Workshop
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
-
Fixed Branches:MOODLE_23_STABLE, MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-37522-published-attachment -
Pull Master Diff URL:
Description
Published submissions throw an error if student is not submitter or reviewer.
Steps to reproduce:
- Enable "Publish submission" for a submission in workshop
- With a participant (student role) who is neither the submitter nor reviewer try to open the submission.
- The user gets a "Sorry, the requested file could not be found" error
As far as I understand the user should be allowed to open the submission if the submission is published and the user has the capability mod/workshop:viewpublishedsubmissions. However, there is no such condition in mod/workshop/lib.php.
The error is thrown in mod/workshop/lib.php, line 1254 (Version 2.3.4 (Build: 20130114))
http://git.moodle.org/gw?p=moodle.git;a=blob;f=mod/workshop/lib.php;h=cf37a23521b7c60fd48e70665e6af16a0fd7269d;hb=refs/heads/MOODLE_23_STABLE#l1254
This issue is related to MDL-32638.
Attachments
Issue Links
- Discovered while testing
-
MDL-38261 Big images attached to workshop submission displayed at their full size
-
- Closed
-