Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37071 Improve Linting of core JS in Moodle
  3. MDL-37526

Fix JSHint issues with moodle-core-notification

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Moodle notification dialogues are used in various places, though currently mostly for exception displays. The new activity chooser also uses them and this is the easiest place to test them.

      • Open a course page
      • Open your JS console
      • Turn editing on
      • Open the Activity chooser
      • Confirm that it works as expected
      • Edit /enrol/ajax.php
      • Add something which has no chance of being parsed by a json parser (e.g. echo "{];"; die
      • Navigate to Course administration -> Users -> Enrolled users
        • Confirm that an error was shown in a dialogue
        • Confirm that no errors were thrown in the console
      Show
      Moodle notification dialogues are used in various places, though currently mostly for exception displays. The new activity chooser also uses them and this is the easiest place to test them. Open a course page Open your JS console Turn editing on Open the Activity chooser Confirm that it works as expected Edit /enrol/ajax.php Add something which has no chance of being parsed by a json parser (e.g. echo "{];"; die Navigate to Course administration -> Users -> Enrolled users Confirm that an error was shown in a dialogue Confirm that no errors were thrown in the console
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      Fix JSHint issues with moodle-core-notification

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13