Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37527

Assignment print course overview query performance

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This is a performance improvement, so not really testable - just check for regressions.

      1. In a course create 3 assignments with file submissions enabled
      2. Login as a student and upload a file submission to each assignment
      3. View the "My home" page for the student (has the course_overview block by default).
      4. Verify there are no reported errors
      5. Login as a teacher for the same course
      6. View the "My home" page for the teacher.
      7. Verify there are no reported errors
      Show
      This is a performance improvement, so not really testable - just check for regressions. In a course create 3 assignments with file submissions enabled Login as a student and upload a file submission to each assignment View the "My home" page for the student (has the course_overview block by default). Verify there are no reported errors Login as a teacher for the same course View the "My home" page for the teacher. Verify there are no reported errors
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
      git@github.com:damyon/moodle.git
    • Pull Master Branch:
      MDL-37527-master
    • Pull Master Diff URL:

      Description

      The query in question is the one to get all user submissions. Please see attached fix, without it indexes are not used.

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37619 Failed unit tests for mod/assign/lib.php

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              bushido Mark Nielsen
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Ankit Agarwal Ankit Agarwal
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Matteo Scaramuccia, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/13