[MDL-37527] Assignment print course overview query performance - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git@github.com:damyon/moodle.git
Pull Master Branch:
~~MDL-37527~~-master
Pull Master Diff URL:
https://github.com/damyon/moodle/compare/50ac16b...MDL-37527-master
Testing Instructions:
Hide

This is a performance improvement, so not really testable - just check for regressions.

In a course create 3 assignments with file submissions enabled

Login as a student and upload a file submission to each assignment

View the "My home" page for the student (has the course_overview block by default).

Verify there are no reported errors

Login as a teacher for the same course

View the "My home" page for the teacher.

Verify there are no reported errors
Show
This is a performance improvement, so not really testable - just check for regressions. In a course create 3 assignments with file submissions enabled Login as a student and upload a file submission to each assignment View the "My home" page for the student (has the course_overview block by default). Verify there are no reported errors Login as a teacher for the same course View the "My home" page for the teacher. Verify there are no reported errors

The query in question is the one to get all user submissions. Please see attached fix, without it indexes are not used.

caused a regression

MDL-37619 Failed unit tests for mod/assign/lib.php

Participants:: Ankit Agarwal, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Kris Stokking, Mark Nielsen

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo