Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37535

Fix block_section_links use of config_plugins

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1
    • Fix Version/s: 2.5
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      Before upgrade...

      1. Log in as an admin.
      2. Browse to Settings > Plugins > Blocks > Section links setting.
      3. Change the default values and remember what you changed them to.
      4. Browse to a course.
      5. Add an instance of the section links block.

      After upgrade...

      1. Log in as an admin
      2. Browse to Settings > Plugins > Blocks > Section links setting.
      3. Make sure the values you selected are still there.
      4. Browse to the course.
      5. Make sure the section links block still works.
      Show
      Before upgrade... Log in as an admin. Browse to Settings > Plugins > Blocks > Section links setting. Change the default values and remember what you changed them to. Browse to a course. Add an instance of the section links block. After upgrade... Log in as an admin Browse to Settings > Plugins > Blocks > Section links setting. Make sure the values you selected are still there. Browse to the course. Make sure the section links block still works.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-37535-m25

      Description

      While reviewing MDL-34344 it was detected that the block_section_links block:

      1) Is storing its plugin settings into blocks/section_links, while it should be using proper component name. So we must move those settings (upgrade) and switch to component.

      2) Surely because of the exceptional (incorrect) plugin name used... the block has implemented the before_delete() method. Once moved to proper component, it should be not needed any more. Standard plugin uninstallation takes rid of related config automatically.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13