Moodle
  1. Moodle
  2. MDL-37537

Course completion report includes a string error

    Details

    • Testing Instructions:
      Hide

      Enable completion in advanced features
      Create course with completion enabled
      Add Completion Status block to course
      Enrol a user in the course
      Under Completion Settings, tick multiple "Manual completion by" roles
      View course completion report as an admin
      Click a participants name to get to details.php
      Missing string appears as [[aggregateall]]

      Show
      Enable completion in advanced features Create course with completion enabled Add Completion Status block to course Enrol a user in the course Under Completion Settings, tick multiple "Manual completion by" roles View course completion report as an admin Click a participants name to get to details.php Missing string appears as [ [aggregateall] ]
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull 2.4 Branch:
    • Pull Master Branch:
    • Rank:
      47185

      Description

      When viewing the Course completion report, focussing on a single student, a string error is reported in the second row of the table...

      Invalid get_string() identifier: 'aggregateall' or component 'completion'. Perhaps you are missing $string['aggregateall'] = ''; in lang/en/completion.php?
      line 6739 of \lib\moodlelib.php: call to debugging()
      line 7400 of \lib\moodlelib.php: call to core_string_manager->get_string()
      line 203 of \blocks\completionstatus\details.php: call to get_string()
      

        Issue Links

          Activity

          Hide
          Chris Follin added a comment -

          We're seeing this in 2.3.3.

          Show
          Chris Follin added a comment - We're seeing this in 2.3.3.
          Hide
          Johan Reinalda added a comment -

          We are also still seeing this in 2.3.6,
          blocks/completionstatus/details.php , line 219:

          echo strtolower(get_string('aggregateall', 'completion'));

          The language file /lang/en/completion.php does not define the string 'aggregateall'

          Please add this simple fix.

          Show
          Johan Reinalda added a comment - We are also still seeing this in 2.3.6, blocks/completionstatus/details.php , line 219: echo strtolower(get_string('aggregateall', 'completion')); The language file /lang/en/completion.php does not define the string 'aggregateall' Please add this simple fix.
          Hide
          Aaron Barnes added a comment -

          Hi guys,

          Catching up on some Course Completion work and this will be my first port of call!

          Cheers,
          Aaron

          Show
          Aaron Barnes added a comment - Hi guys, Catching up on some Course Completion work and this will be my first port of call! Cheers, Aaron
          Hide
          Jason Fowler added a comment -

          [Y] Syntax
          [Y] Output
          [Y] Whitespace
          [Y] Language
          [-] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Show
          Jason Fowler added a comment - [Y] Syntax [Y] Output [Y] Whitespace [Y] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check
          Hide
          Jason Fowler added a comment -

          would you like to backport this to 2.3 and 2.4 too?

          Show
          Jason Fowler added a comment - would you like to backport this to 2.3 and 2.4 too?
          Hide
          Johan Reinalda added a comment -

          Yes, please backport into 2.3 and 2.4

          Show
          Johan Reinalda added a comment - Yes, please backport into 2.3 and 2.4
          Hide
          Jason Fowler added a comment -

          These should be backported to the stable branches.

          Show
          Jason Fowler added a comment - These should be backported to the stable branches.
          Hide
          Dan Poltawski added a comment -

          Integrated to master, 24 and 23. Thanks Aaron

          Show
          Dan Poltawski added a comment - Integrated to master, 24 and 23. Thanks Aaron
          Hide
          Frédéric Massart added a comment -

          Test is passing, however I noticed a couple of minor problems, I will raise an issue for each of them:

          • MDL-39124: Names of roles are not displayed in completion tracking
          • MDL-39125: Completion progress details text need separation

          I think the later is closely related to this bug.

          Show
          Frédéric Massart added a comment - Test is passing, however I noticed a couple of minor problems, I will raise an issue for each of them: MDL-39124 : Names of roles are not displayed in completion tracking MDL-39125 : Completion progress details text need separation I think the later is closely related to this bug.
          Hide
          Dan Poltawski added a comment -

          Blooming Marvelous! It's time for a knees up - your changes are upstream!

          Thanks for making Moodle better!

          Toodle pip

          Show
          Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: