Moodle
  1. Moodle
  2. MDL-37539

Assignment upgrade always enables submission comments for advanced upload of files assignments

    Details

    • Testing Instructions:
      Hide
      1. Create 2 of the "Advanced uploading of files" old assignments with these settings:
        1. A) "Allow Notes" = No
        2. B) "Allow Notes" = Yes
      2. Upgrade both assignments with the assignment upgrade tool
      3. Verify the settings for the upgraded new assignments:
        1. A) "Submission comments" = No
        2. B) "Submission comments" = Yes
      Show
      Create 2 of the "Advanced uploading of files" old assignments with these settings: A) "Allow Notes" = No B) "Allow Notes" = Yes Upgrade both assignments with the assignment upgrade tool Verify the settings for the upgraded new assignments: A) "Submission comments" = No B) "Submission comments" = Yes
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
      git@github.com:damyon/moodle.git
    • Pull 2.4 Branch:
    • Pull Master Branch:
      MDL-37539-master
    • Rank:
      47187

      Description

      Even if "Allow notes" is disabled for an advanced upload of files assignment, when it is upgraded submission comments will be enabled.

        Activity

        Hide
        Damyon Wiese added a comment -

        Reported by Russell Craythorn.

        Show
        Damyon Wiese added a comment - Reported by Russell Craythorn.
        Hide
        Damyon Wiese added a comment -

        Setting blocker links to avoid conflicts.

        Show
        Damyon Wiese added a comment - Setting blocker links to avoid conflicts.
        Hide
        Damyon Wiese added a comment -

        Actually - this wont have conflicts - link removed.

        Show
        Damyon Wiese added a comment - Actually - this wont have conflicts - link removed.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
        Hide
        Damyon Wiese added a comment -

        This causes a failure in the unit tests on master.

        I added a patch to the master branch to fix this (it is the test that needs changing).

        Show
        Damyon Wiese added a comment - This causes a failure in the unit tests on master. I added a patch to the master branch to fix this (it is the test that needs changing).
        Hide
        Eloy Lafuente (stronk7) added a comment -

        pushed! Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - pushed! Thanks!
        Hide
        Mark Nelson added a comment -

        Works as expected, passing. Thanks Damyon.

        Show
        Mark Nelson added a comment - Works as expected, passing. Thanks Damyon.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: