Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide
      1. Open any page with filemanager
      2. Search any string in wikimedia
      3. Click on file and make sure image dimensions, license, author and last modified date are displayed
      4. For some images (that are less than set maximum width and height) also the file size in bytes will be displayed
      5. Check that images are resized to the specified boundaries
      Show
      Open any page with filemanager Search any string in wikimedia Click on file and make sure image dimensions, license, author and last modified date are displayed For some images (that are less than set maximum width and height) also the file size in bytes will be displayed Check that images are resized to the specified boundaries
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-37541-master
    • Rank:
      47189

      Description

      see parent issue

        Activity

        Hide
        Marina Glancy added a comment -

        All data returned by mediawiki search has license
        Creative Commons Attribution-Share Alike 3.0 Unported"

        the closest match in our licenses list is:
        $string['cc-sa'] = 'Creative Commons - ShareAlike';

        Show
        Marina Glancy added a comment - All data returned by mediawiki search has license Creative Commons Attribution-Share Alike 3.0 Unported" the closest match in our licenses list is: $string ['cc-sa'] = 'Creative Commons - ShareAlike';
        Hide
        Marina Glancy added a comment -

        TO INTEGRATORS: feel free to cherry-pick to 2.4, this is just improvement to one repository plugin. Wikimedia repository plugin is the only external plugin enabled in moodle by default so it makes sense to have it working correctly

        Show
        Marina Glancy added a comment - TO INTEGRATORS: feel free to cherry-pick to 2.4, this is just improvement to one repository plugin. Wikimedia repository plugin is the only external plugin enabled in moodle by default so it makes sense to have it working correctly
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Aparup Banerjee added a comment -

        thanks Marina, this looks good. This is really isolated and yet again i'm compelled to agree about backporting this BUT..I'll just get a vote for back-porting from integrators, current trends are to really cut down on unnecessary back ports.

        Show
        Aparup Banerjee added a comment - thanks Marina, this looks good. This is really isolated and yet again i'm compelled to agree about backporting this BUT..I'll just get a vote for back-porting from integrators, current trends are to really cut down on unnecessary back ports.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        does fetching that information helps for sync-ing or something else apart from the user experience ?

        If so I'd see it as backportable, else I wouldn't backport it by default (only if the masses require it).

        Show
        Eloy Lafuente (stronk7) added a comment - does fetching that information helps for sync-ing or something else apart from the user experience ? If so I'd see it as backportable, else I wouldn't backport it by default (only if the masses require it).
        Hide
        Marina Glancy added a comment -

        This is UI only - showing image size.
        Since you agreed to integrate it in master only I also added a commit that allows user to set the maximum width and height to resize found images. Wikimedia has this feature so I thought why not use it. Before that it was hardcoded to 1024x1024, this is now default.

        Show
        Marina Glancy added a comment - This is UI only - showing image size. Since you agreed to integrate it in master only I also added a commit that allows user to set the maximum width and height to resize found images. Wikimedia has this feature so I thought why not use it. Before that it was hardcoded to 1024x1024, this is now default.
        Hide
        Aparup Banerjee added a comment -

        ok cool, thats been integrated now into master only.

        Show
        Aparup Banerjee added a comment - ok cool, thats been integrated now into master only.
        Hide
        Mark Nelson added a comment -

        Works as expected, thanks Marina. Passing.

        Show
        Mark Nelson added a comment - Works as expected, thanks Marina. Passing.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao
        Hide
        Mary Cooch added a comment -

        Removing docs_required as this is documented here http://docs.moodle.org/25/en/Wikimedia_repository

        Show
        Mary Cooch added a comment - Removing docs_required as this is documented here http://docs.moodle.org/25/en/Wikimedia_repository

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: