Moodle
  1. Moodle
  2. MDL-37543

Assignment upgrade does not preserve setting "Enable send for marking button".

    Details

    • Testing Instructions:
      Hide
      1. Create 4 instances of the old assignment
        1. A) - advanced upload files with "Enable send for marking button" No
        2. B) - advanced upload files with "Enable send for marking button" Yes
        3. C) - onlinetext with "Allow resubmitting" No
        4. D) - onlinetext with "Allow resubmitting" Yes
      2. Use the assignment upgrade tool to upgrade all 4 assignments
      3. Verify that the "Require students click submit button" is set as follows:
        1. A) No
        2. B) Yes
        3. C) No
        4. D) Yes
      Show
      Create 4 instances of the old assignment A) - advanced upload files with "Enable send for marking button" No B) - advanced upload files with "Enable send for marking button" Yes C) - onlinetext with "Allow resubmitting" No D) - onlinetext with "Allow resubmitting" Yes Use the assignment upgrade tool to upgrade all 4 assignments Verify that the "Require students click submit button" is set as follows: A) No B) Yes C) No D) Yes
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
      git@github.com:damyon/moodle.git
    • Pull Master Branch:
      MDL-37543-master

      Description

      For advanced upload of files, the assignment upgrade does not preserve the value of this setting (it is stored in var4 - not resubmit).

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Aparup Banerjee added a comment -

            Hi Damyon,
            this looks alright. i was about to integrate this when i thought about folks who've already upgraded.
            is there anyway to look up the old assignment and preserve previous upgrades? should we? i'm not too bothered as it can always be set manually but just putting this out here.

            Show
            Aparup Banerjee added a comment - Hi Damyon, this looks alright. i was about to integrate this when i thought about folks who've already upgraded. is there anyway to look up the old assignment and preserve previous upgrades? should we? i'm not too bothered as it can always be set manually but just putting this out here.
            Hide
            Damyon Wiese added a comment -

            It would be nice but once they have upgraded without this patch the info is gone (the old course module gets deleted).

            Show
            Damyon Wiese added a comment - It would be nice but once they have upgraded without this patch the info is gone (the old course module gets deleted).
            Hide
            Aparup Banerjee added a comment -

            Thanks, integrated now into 23, 24 and master for testing.

            Show
            Aparup Banerjee added a comment - Thanks, integrated now into 23, 24 and master for testing.
            Hide
            Mark Nelson added a comment -

            Works as expected, passing.

            Show
            Mark Nelson added a comment - Works as expected, passing.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

            Closing as fixed, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: