Moodle
  1. Moodle
  2. MDL-37563

Assignment upgrade does not include conditional access settings.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. For the site enable conditional access (advanced settings)
      2. For a course set Completion tracking to "Enabled, control via completion and activity settings"
      3. Create an instance of "Advanced uploading of files"
      4. Settings
        1. (Restrict access section)
        2. Allow access from (Set to today)
        3. Allow access until (Set to 1 week)
        4. User field "First name" contains "a" (Only on 2.4+)
        5. Before activity can be accessed "Show activity greyed-out with restriction information"
        6. (Activity completion section)
        7. Completion tracking: "Students can manually mark the activity as completed"
      5. Create another "Advanced uploading of files" assignment
      6. Settings
        1. (Restrict access section)
        2. Grade condition "first assignment" must be at least 50%
        3. Activity completion condition "first assignment" must be marked complete
        4. Before activity can be accessed "Show activity greyed-out with restriction information"
      7. Configure the next section for the course
        1. (Restrict access section)
        2. Grade condition "first assignment" must be at least 50%
        3. Activity completion condition "first assignment" must be marked complete
        4. Before section can be accessed "Show section greyed-out with restriction information"
      8. Upgrade both assignments with the assignment upgrade tool.
      9. Verify that all conditional access settings remain unchanged.
      Show
      For the site enable conditional access (advanced settings) For a course set Completion tracking to "Enabled, control via completion and activity settings" Create an instance of "Advanced uploading of files" Settings (Restrict access section) Allow access from (Set to today) Allow access until (Set to 1 week) User field "First name" contains "a" (Only on 2.4+) Before activity can be accessed "Show activity greyed-out with restriction information" (Activity completion section) Completion tracking: "Students can manually mark the activity as completed" Create another "Advanced uploading of files" assignment Settings (Restrict access section) Grade condition "first assignment" must be at least 50% Activity completion condition "first assignment" must be marked complete Before activity can be accessed "Show activity greyed-out with restriction information" Configure the next section for the course (Restrict access section) Grade condition "first assignment" must be at least 50% Activity completion condition "first assignment" must be marked complete Before section can be accessed "Show section greyed-out with restriction information" Upgrade both assignments with the assignment upgrade tool. Verify that all conditional access settings remain unchanged.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
      git@github.com:damyon/moodle.git
    • Pull 2.4 Branch:
    • Pull Master Branch:
      MDL-37563-master
    • Rank:
      47215

      Description

      The assignment upgrade tool does not upgrade conditional access conditions for the activity.

        Activity

        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Hi Damyon,

        The course_modules_avail_fields was added by MDL-29538 in 2.4.
        The 23 branch needs to be fixed up and can you please give it a quick test.

        As it looks like a very simple fix I'll leave this in integration.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Hi Damyon, The course_modules_avail_fields was added by MDL-29538 in 2.4. The 23 branch needs to be fixed up and can you please give it a quick test. As it looks like a very simple fix I'll leave this in integration. Many thanks Sam
        Hide
        Damyon Wiese added a comment -

        Thanks Sam, good spotting.

        I have fixed and pushed the 23 branch. I ran through the test instructions on the 23 branch and they worked fine.

        Show
        Damyon Wiese added a comment - Thanks Sam, good spotting. I have fixed and pushed the 23 branch. I ran through the test instructions on the 23 branch and they worked fine.
        Hide
        Sam Hemelryk added a comment -

        Thanks Damyon, this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Damyon, this has been integrated now
        Hide
        Jason Fowler added a comment -

        All working fine Damyon, thanks for the patch!

        Show
        Jason Fowler added a comment - All working fine Damyon, thanks for the patch!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: