Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37571

Wrong ID used for element in filter form

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1
    • Fix Version/s: 2.5
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      1. Log in as admin
      2. Go to Language customisation (Home ► Site administration ► Language ► Language customisation)
      3. Select any language pack and open it.
      4. Make sure "Modified only" checkbox is not selected.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Wrong ID used in the admin/tool/customlang/filter_form.php

              $mform->addElement('advcheckbox', 'modified', get_string('filtermodified', 'tool_customlang'));
              $mform->setType('filtermodified', PARAM_BOOL);
              $mform->setDefault('filtermodified', 0);
      

        Gliffy Diagrams

          Activity

          Hide
          tmuras Tomasz Muras added a comment -

          This is a minor bug fix, no need for back-porting it to stable releases - apply to master only.

          Show
          tmuras Tomasz Muras added a comment - This is a minor bug fix, no need for back-porting it to stable releases - apply to master only.
          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          Thanks Tomosaz, for reporting it and providing spot-on patch.

          Pushing it for integration review.
          [y] Syntax
          [y] Output
          [y] Whitespace
          [-] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Show
          rajeshtaneja Rajesh Taneja added a comment - Thanks Tomosaz, for reporting it and providing spot-on patch. Pushing it for integration review. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
          Hide
          poltawski Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          nebgor Aparup Banerjee added a comment -

          thanks, this has been integrated into master now.
          checkbox is unchecked for me.

          Show
          nebgor Aparup Banerjee added a comment - thanks, this has been integrated into master now. checkbox is unchecked for me.
          Hide
          fred Frédéric Massart added a comment -

          Passed. Thanks!

          PS: Shouldn't this be backported?

          Show
          fred Frédéric Massart added a comment - Passed. Thanks! PS: Shouldn't this be backported?
          Hide
          rajeshtaneja Rajesh Taneja added a comment - - edited

          Hello Fred,

          It's not really required on stable branches, as it's not breaking anything, just rectifying default value, which is by default 0.

          Show
          rajeshtaneja Rajesh Taneja added a comment - - edited Hello Fred, It's not really required on stable branches, as it's not breaking anything, just rectifying default value, which is by default 0.
          Hide
          fred Frédéric Massart added a comment -

          Well, I could call that a bug ! And I don't see any risks backporting it. Just a thought anyway.

          Show
          fred Frédéric Massart added a comment - Well, I could call that a bug ! And I don't see any risks backporting it. Just a thought anyway.
          Hide
          nebgor Aparup Banerjee added a comment -

          This one is easily correctable by the user so functionality wasn't strictly broken imo. I guess you could call it one of those 'reasons to upgrade your moodle' kind of fixes :-D

          Show
          nebgor Aparup Banerjee added a comment - This one is easily correctable by the user so functionality wasn't strictly broken imo. I guess you could call it one of those 'reasons to upgrade your moodle' kind of fixes :-D
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

          Closing as fixed, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13