Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37583

Junk copy-and-paste code in mod/quiz/report/statistics/report.php

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5
    • Component/s: Quiz
    • Labels:

      Description

      Doh! I copied and pasted some code into mod/quiz/report/statistics/report.php in order to refer to while implementing the render_question_text method, and then is seems I comitted it and it got integrated.

      We should clean it up.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Submitting for integration.

            Show
            timhunt Tim Hunt added a comment - Submitting for integration.
            Hide
            timhunt Tim Hunt added a comment -

            Not sure if this sort of clean-up should be back-ported or not. Integrators, it is safe to back-port, if you want.

            Show
            timhunt Tim Hunt added a comment - Not sure if this sort of clean-up should be back-ported or not. Integrators, it is safe to back-port, if you want.
            Hide
            nebgor Aparup Banerjee added a comment -

            looks good for master.

            safe to back-port but its not unsafe to remain there is it? (for the off-chance that a single person in the world is using it and theres no issue with it staying there for stables. Clean up within stables can be a risk.).

            Show
            nebgor Aparup Banerjee added a comment - looks good for master. safe to back-port but its not unsafe to remain there is it? (for the off-chance that a single person in the world is using it and theres no issue with it staying there for stables. Clean up within stables can be a risk.).
            Hide
            timhunt Tim Hunt added a comment - - edited

            I think that given the discussion in MDL-37585, this should be master-only. It is safe for that code to remain. It has been there for a while. It just makes me look a bit careless, but that is fair enough. I was.

            Show
            timhunt Tim Hunt added a comment - - edited I think that given the discussion in MDL-37585 , this should be master-only. It is safe for that code to remain. It has been there for a while. It just makes me look a bit careless, but that is fair enough. I was.
            Hide
            nebgor Aparup Banerjee added a comment -

            yup cool thanks, this has been integrated into master only now for testing.

            Show
            nebgor Aparup Banerjee added a comment - yup cool thanks, this has been integrated into master only now for testing.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This is working as expected.

            Tested for Master only.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This is working as expected. Tested for Master only. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

            Closing as fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13