Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37598

Drop ABORT_AFTER_CONFIG from theme/yui_combo.php

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing difficulty: Trivial

      Standard regression test: Purge caches and make sure that Javascript works here and there. More technically (if using some browser extension that monitors the request traffic), make sure that loading theme/yui_combo.php and theme/yui_image.php still works.

      Show
      Testing difficulty: Trivial Standard regression test: Purge caches and make sure that Javascript works here and there. More technically (if using some browser extension that monitors the request traffic), make sure that loading theme/yui_combo.php and theme/yui_image.php still works.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37598-abort-after-config

      Description

      While working on adding MUC support into plugin related core functions, I am facing yet another issue. The script theme/yui_combo.php defines ABORT_AFTER_CONFIG and thence the MUC libraries are not loaded during the setup. But then the script calls get_component_directory() which in turn ends by calling plugin related methods with the MUC support.

      PHP Fatal error:  Class 'cache' not found
      

      and JS not loaded.

      https://github.com/mudrd8mz/moodle/compare/master...MDL-34401-muc-pluginlib shows my work in progress on MDL-34401

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Peer reviewer:
              Petr Skoda
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13