Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37598

Drop ABORT_AFTER_CONFIG from theme/yui_combo.php

XMLWordPrintable

    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • MDL-37598-abort-after-config
    • Hide

      Testing difficulty: Trivial

      Standard regression test: Purge caches and make sure that Javascript works here and there. More technically (if using some browser extension that monitors the request traffic), make sure that loading theme/yui_combo.php and theme/yui_image.php still works.

      Show
      Testing difficulty: Trivial Standard regression test: Purge caches and make sure that Javascript works here and there. More technically (if using some browser extension that monitors the request traffic), make sure that loading theme/yui_combo.php and theme/yui_image.php still works.

      While working on adding MUC support into plugin related core functions, I am facing yet another issue. The script theme/yui_combo.php defines ABORT_AFTER_CONFIG and thence the MUC libraries are not loaded during the setup. But then the script calls get_component_directory() which in turn ends by calling plugin related methods with the MUC support.

      PHP Fatal error:  Class 'cache' not found

      and JS not loaded.

      https://github.com/mudrd8mz/moodle/compare/master...MDL-34401-muc-pluginlib shows my work in progress on MDL-34401

            mudrd8mz David Mudrák (@mudrd8mz)
            mudrd8mz David Mudrák (@mudrd8mz)
            Petr Skoda Petr Skoda
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.