Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37602

Overall feedback from the peer reviewer comment

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: easy

      1. Create a new workshop instance. In the Assessment settings part of the form, enable the Overall feedback feature and allow attaching files to the overall feedback.
      2. Define the assessment form (the actual grading strategy should not matter) and switch the workshop into the submission phase.
      3. Let students submit their work (usual hint: http://docs.moodle.org/dev/Workshop/fakesubmissions.php) and allocate submissions for assessment.
      4. Switch the workshop into the assessment phase and log in as a workshop participant (student).
      5. TEST: Make sure that there is the editor and file manager displayed below the assessment form when providing the peer-assessment. The peer-reviewer is able to put the overall feedback for the submission author and attach files (if enabled in the workshop settings form).
      6. As the teacher/admin, close the workshop activity.
      7. TEST: Make sure that the overall feedback is displayed to the submission author together with the filled assessment form.

      Thanks for your time spent on testing this!

      Show
      Testing difficulty: easy 1. Create a new workshop instance. In the Assessment settings part of the form, enable the Overall feedback feature and allow attaching files to the overall feedback. 2. Define the assessment form (the actual grading strategy should not matter) and switch the workshop into the submission phase. 3. Let students submit their work (usual hint: http://docs.moodle.org/dev/Workshop/fakesubmissions.php ) and allocate submissions for assessment. 4. Switch the workshop into the assessment phase and log in as a workshop participant (student). 5. TEST: Make sure that there is the editor and file manager displayed below the assessment form when providing the peer-assessment. The peer-reviewer is able to put the overall feedback for the submission author and attach files (if enabled in the workshop settings form). 6. As the teacher/admin, close the workshop activity. 7. TEST: Make sure that the overall feedback is displayed to the submission author together with the filled assessment form. Thanks for your time spent on testing this!
    • Workaround:
      Hide

      Whisper "strč prst skrz krk" (which mean something like "put your finger through a throat" in Czech) three times.

      Show
      Whisper "strč prst skrz krk" (which mean something like "put your finger through a throat" in Czech) three times.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37602-workshop-overall-feedback

      Description

      While there is a comment box for the reviewers to comment in, I would like a way to require that the student types something in the box before moving on. I have hundreds of students and the workshop tool has allowed me to institute valuable written assignments in my classes that would otherwise be too labor intensive.

      Students often complain that they don't get any feedback. I would like to require that the comment box has text in it before an assessment can be submitted.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            mudrd8mz David Mudrak added a comment -

            Yup, this is a known requirement. Please see MDL-27237 for more details and background.

            This should not be difficult to implement, let us aim for 2.5.

            Show
            mudrd8mz David Mudrak added a comment - Yup, this is a known requirement. Please see MDL-27237 for more details and background. This should not be difficult to implement, let us aim for 2.5.
            Hide
            japomani Jared R. Chapman added a comment -

            Thanks David, this is by far the best peer review tool available any where. Thank you!

            Show
            japomani Jared R. Chapman added a comment - Thanks David, this is by far the best peer review tool available any where. Thank you!
            Hide
            mudrd8mz David Mudrak added a comment -

            So there are three things to do

            • Add a HTML text field at the bottom of every assessment form (regardless the grading strategy) labelled as "Overall feedback"
            • Add a possibility to attach a file to this overall feedback (if enabled). Such an attachment would be available for the author, for the reviewer and for teachers
            • Add an option to mark the Overall feedback field as Required (that is, the reviewer has to put something in it).
            Show
            mudrd8mz David Mudrak added a comment - So there are three things to do Add a HTML text field at the bottom of every assessment form (regardless the grading strategy) labelled as "Overall feedback" Add a possibility to attach a file to this overall feedback (if enabled). Such an attachment would be available for the author, for the reviewer and for teachers Add an option to mark the Overall feedback field as Required (that is, the reviewer has to put something in it).
            Hide
            japomani Jared R. Chapman added a comment -

            Thanks David, it looks great!

            Show
            japomani Jared R. Chapman added a comment - Thanks David, it looks great!
            Hide
            mudrd8mz David Mudrak added a comment -

            Submitting for integration.

            • The patchset adds required DB fields to hold the feature settings and data (the fields feedbackauthor and feedbackauthorformat have been present in mdl_workshop_assessment since 2.0, they just were not used yet until now).
            • Added support for editing the overall feedback including embedded media and attached files.
            • Added support for displaying the overall feedback where appropriate.
            • New database fields and files included in backup and restore processing.
            Show
            mudrd8mz David Mudrak added a comment - Submitting for integration. The patchset adds required DB fields to hold the feature settings and data (the fields feedbackauthor and feedbackauthorformat have been present in mdl_workshop_assessment since 2.0, they just were not used yet until now). Added support for editing the overall feedback including embedded media and attached files. Added support for displaying the overall feedback where appropriate. New database fields and files included in backup and restore processing.
            Hide
            damyon Damyon Wiese added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            Thanks!

            Show
            damyon Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master - thanks David!

            Show
            poltawski Dan Poltawski added a comment - Integrated to master - thanks David!
            Hide
            poltawski Dan Poltawski added a comment - - edited

            Bah, Failing - this is causing unit test breakage

            mod_workshop_internal_api_testcase::test_prepare_example_reference_assessment
            coding_exception: Coding error detected, it must be fixed by a programmer: Assessment record must provide public property feedbackauthor
             
            /var/lib/jenkins/git_repositories/master/mod/workshop/locallib.php:3272
            /var/lib/jenkins/git_repositories/master/mod/workshop/locallib.php:1022
            /var/lib/jenkins/git_repositories/master/mod/workshop/tests/locallib_test.php:386
            /var/lib/jenkins/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76
            

            mod_workshop_internal_api_testcase::test_prepare_example_assessment
            coding_exception: Coding error detected, it must be fixed by a programmer: Assessment record must provide public property feedbackauthor
            /var/lib/jenkins/git_repositories/master/mod/workshop/locallib.php:3272
            /var/lib/jenkins/git_repositories/master/mod/workshop/locallib.php:986
            /var/lib/jenkins/git_repositories/master/mod/workshop/tests/locallib_test.php:360
            /var/lib/jenkins/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76
            

            Show
            poltawski Dan Poltawski added a comment - - edited Bah, Failing - this is causing unit test breakage mod_workshop_internal_api_testcase::test_prepare_example_reference_assessment coding_exception: Coding error detected, it must be fixed by a programmer: Assessment record must provide public property feedbackauthor   /var/lib/jenkins/git_repositories/master/mod/workshop/locallib.php:3272 /var/lib/jenkins/git_repositories/master/mod/workshop/locallib.php:1022 /var/lib/jenkins/git_repositories/master/mod/workshop/tests/locallib_test.php:386 /var/lib/jenkins/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76 mod_workshop_internal_api_testcase::test_prepare_example_assessment coding_exception: Coding error detected, it must be fixed by a programmer: Assessment record must provide public property feedbackauthor /var/lib/jenkins/git_repositories/master/mod/workshop/locallib.php:3272 /var/lib/jenkins/git_repositories/master/mod/workshop/locallib.php:986 /var/lib/jenkins/git_repositories/master/mod/workshop/tests/locallib_test.php:360 /var/lib/jenkins/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76
            Hide
            mudrd8mz David Mudrak added a comment -

            Shame on me. Sorry, I had to miss this bit somehow. I just committed additional patch 5582ea0a9b06374b9ccea1ba7258337dcfb63f11 on top of the branch, so you can just re-pull or cherry-pick that one.

            Show
            mudrd8mz David Mudrak added a comment - Shame on me. Sorry, I had to miss this bit somehow. I just committed additional patch 5582ea0a9b06374b9ccea1ba7258337dcfb63f11 on top of the branch, so you can just re-pull or cherry-pick that one.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks David, i've pulled that in and tested locally. We'll wait for jenkins to give us the green light now

            Show
            poltawski Dan Poltawski added a comment - Thanks David, i've pulled that in and tested locally. We'll wait for jenkins to give us the green light now
            Hide
            dmonllao David Monllaó added a comment -

            Tested in master. I can see the submission and the peer assessment with the grade, the comments and the feedback files

            Show
            dmonllao David Monllaó added a comment - Tested in master. I can see the submission and the peer assessment with the grade, the comments and the feedback files
            Hide
            poltawski Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            poltawski Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
            Hide
            marycooch Mary Cooch added a comment -

            Removing docs_required label as this is documented here http://docs.moodle.org/25/en/Workshop_settings

            Show
            marycooch Mary Cooch added a comment - Removing docs_required label as this is documented here http://docs.moodle.org/25/en/Workshop_settings

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13