Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36666 META - Multiple pages apply generalbox class instead of generaltable class to tables
  3. MDL-37614

Change generalbox class to generaltable class in report/completion/user.php

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.4
          • Fix Version/s: 2.5
          • Component/s: Reports
          • Labels:
          • Testing Instructions:
            Hide

            I'm not sure if this needs testing as it is just renaming a css class which is predefined for the purpose it is meant for. So the tables in this change will be consistent with other tables in Moodle.

            Show
            I'm not sure if this needs testing as it is just renaming a css class which is predefined for the purpose it is meant for. So the tables in this change will be consistent with other tables in Moodle.
          • Affected Branches:
            MOODLE_24_STABLE
          • Fixed Branches:
            MOODLE_25_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-37614_master
          • Pull Master Diff URL:

            Description

            Affected file...

            • report/completion/user.php

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                  TIA and ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                  Hide
                  Permalink
                  lazydaisy Mary Evans added a comment -

                  RE-BASED

                  Show
                  lazydaisy Mary Evans added a comment - RE-BASED
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Mary - has been integrated now.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Mary - has been integrated now.
                  Hide
                  Permalink
                  jerome Jérôme Mouneyrac added a comment -

                  Nothing to test, passed.

                  Show
                  jerome Jérôme Mouneyrac added a comment - Nothing to test, passed.
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

                  (and won't be revisiting it unless some regression is found)

                  Thanks and ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      3 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        14/May/13