Moodle
  1. Moodle
  2. MDL-36666 META - Multiple pages apply generalbox class instead of generaltable class to tables
  3. MDL-37614

Change generalbox class to generaltable class in report/completion/user.php

        Details

        • Type: Sub-task Sub-task
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.4
        • Fix Version/s: 2.5
        • Component/s: Reports
        • Labels:
        • Testing Instructions:
          Hide

          I'm not sure if this needs testing as it is just renaming a css class which is predefined for the purpose it is meant for. So the tables in this change will be consistent with other tables in Moodle.

          Show
          I'm not sure if this needs testing as it is just renaming a css class which is predefined for the purpose it is meant for. So the tables in this change will be consistent with other tables in Moodle.
        • Affected Branches:
          MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          wip-MDL-37614_master
        • Pull Master Diff URL:
        • Rank:
          47304

          Description

          Affected file...

          • report/completion/user.php

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Permalink
            Mary Evans added a comment -

            RE-BASED

            Show
            Mary Evans added a comment - RE-BASED
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Thanks Mary - has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Mary - has been integrated now.
            Hide
            Permalink
            Jérôme Mouneyrac added a comment -

            Nothing to test, passed.

            Show
            Jérôme Mouneyrac added a comment - Nothing to test, passed.
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

            (and won't be revisiting it unless some regression is found)

            Thanks and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: