Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37626

Include .jshintrc to moodle.git

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.5
    • 2.4.1
    • JavaScript
    • MOODLE_24_STABLE
    • MOODLE_25_STABLE
    • Hide

      Install node.js and then install jshint (npm install -g jshint).

      • Try passing a few files through jshint:
        1. lib/yui/chooserdialogue/chooserdialogue.js
        2. lib/yui/formautosubmit/formautosubmit.js
        3. lib/yui/formchangechecker/formchangechecker.js
      • Open up the config and change the "strict" option to true
      • Rerun the tests
      • Confirm that some errors were shown this time
      • Try through some files we haven't yet cleaned up:
        1. lib/yui/notification/notification.js
      Show
      Install node.js and then install jshint (npm install -g jshint). Try passing a few files through jshint: lib/yui/chooserdialogue/chooserdialogue.js lib/yui/formautosubmit/formautosubmit.js lib/yui/formchangechecker/formchangechecker.js Open up the config and change the "strict" option to true Rerun the tests Confirm that some errors were shown this time Try through some files we haven't yet cleaned up: lib/yui/notification/notification.js

      It would be particularly good if we could add the .jshintrc to moodle.git
      I know that we haven't 100% finalised on a tool yet, but at present, I'm trying to encourage all changed and new JS to be jshinted and this would make our life easier.

      I suggest that we start with the jshint settings used by YUI: https://raw.github.com/yui/yui-lint/master/jshint.json

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Dan Poltawski Dan Poltawski
            Damyon Wiese Damyon Wiese
            David Monllaó David Monllaó
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.