Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37634

qtype readquestion method visibility inconsistency

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4, 2.5
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Lesson
    • Labels:
      None
    • Testing Instructions:
      Hide

      Import questoins in as many supported formats as possible onto the question bank and the lesson module.

      You can find example files in places like question/format/xxx/tests/fixtures.

      Show
      Import questoins in as many supported formats as possible onto the question bank and the lesson module. You can find example files in places like question/format/xxx/tests/fixtures.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When trying to import questions with the lesson module I receive a fatal error regarding qformat_learnwise::readquestion() method visibility.

      I haven't gone deep into the code but mod/lesson/format.php->qformat_default->readquestion() has public visibility and question/format.php->qformat_default->readquestion() protected, the different qformats are also using different visibilities but the problem is caused when extending to a lower level of visibility.

      I experience the problem with MDL-37068 integrated but I guess the problem is with mod/lesson/format.php->qformat_default->readquestion() that should be protected.

      Fatal error: Access level to qformat_learnwise::readquestion() must be public (as in class qformat_default) in /home/davidm/Desktop/moodlecode/INTEGRATION/MOODLE_23_STABLE/question/format/learnwise/format.php on line 189
      Call Stack
      #	Time	Memory	Function	Location
      1	0.0004	260392	{main}( )	../import.php:0
      2	0.2158	26662392	lesson_get_import_export_formats( )	../import.php:55
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13