Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37638

When cloning a role the default "Custom full name" is incorrect.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.4.2
    • Component/s: Roles / Access
    • Labels:
      None
    • Testing Instructions:
      Hide

      0/ you need a site installed in 2.4, not earlier
      1/ Site administration / ▶ Users / ▶ Permissions / ▶ Define roles
      2/ Clone some standard role which has non-empty name
      3/ verify the default new role name is the same of old one + ' copy'

      Show
      0/ you need a site installed in 2.4, not earlier 1/ Site administration / ▶ Users / ▶ Permissions / ▶ Define roles 2/ Clone some standard role which has non-empty name 3/ verify the default new role name is the same of old one + ' copy'
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w04_MDL-37638_m25_rolecloning

      Description

      When cloning the role "manager" in 2.3 custom full name is "manager copy". In 2.4 and master it is now " copy".

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              Thanks for the report.

              Show
              skodak Petr Skoda added a comment - Thanks for the report.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Petr - has been integrated now.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Petr - has been integrated now.
              Hide
              damyon Damyon Wiese added a comment -

              Applying some common sense to the testing instructions.

              Show
              damyon Damyon Wiese added a comment - Applying some common sense to the testing instructions.
              Hide
              damyon Damyon Wiese added a comment -

              Tested on 24 and master. Works great - thanks!

              Show
              damyon Damyon Wiese added a comment - Tested on 24 and master. Works great - thanks!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

              (and won't be revisiting it unless some regression is found)

              Thanks and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13