Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37645

Generalise the CSS for moodle dialogues

XMLWordPrintable

    • MOODLE_24_STABLE
    • MOODLE_25_STABLE
    • Hide
      • Open a course
      • Turn editing on
      • Open the activity chooser
        • Confirm that it all looks fine
      • edit /enrol/ajax.php
        • After the define('AJAX_SCRIPT', true); line, add: 

          throw new moodle_exception('mdl-37645');

      • open Course administration -> Users -> Enrolled users
        • Confirm that the styling on the exception is pleasing to the eye and congruent with other Moodle dialogues
      Show
      Open a course Turn editing on Open the activity chooser Confirm that it all looks fine edit /enrol/ajax.php After the define('AJAX_SCRIPT', true); line, add: throw new moodle_exception('mdl-37645'); open Course administration -> Users -> Enrolled users Confirm that the styling on the exception is pleasing to the eye and congruent with other Moodle dialogues

      Recent JS dialogue work in Moodle has started to make heavier use of M.core.dialogue provided by lib/yui/notification/notification.js.

      At present, use of this dialogue/class is largely limited to:

      • chooser dialogues (activity chooser); and
      • JS exceptions/errors.

      I'm also working on MDL-35819 which also looks to use the same dialogue for all help popups in Moodle.

      I've done some work on the theming of these dialogues to make them more consistent with the rest of Moodle, so submitting to the wrath of the theme team.

        1. MDL-37645-rtl-closebutton.jpg
          MDL-37645-rtl-closebutton.jpg
          22 kB
        2. Screen Shot 2013-01-30 at 16.16.22.png
          Screen Shot 2013-01-30 at 16.16.22.png
          22 kB
        3. Screen Shot 2013-01-30 at 16.16.39.png
          Screen Shot 2013-01-30 at 16.16.39.png
          19 kB
        4. Screen Shot 2013-02-07 at 13.56.04.png
          Screen Shot 2013-02-07 at 13.56.04.png
          42 kB

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Mary Evans Mary Evans
            Dan Poltawski Dan Poltawski
            Frédéric Massart Frédéric Massart
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.