Moodle
  1. Moodle
  2. MDL-37646

Quick Grading not able to save changes if filter applied

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an assignment in a course with 2 or more students
        1. Set "Require students click submit button" to "No"
        2. File submissions to "Yes"
      2. Login as at least 2 students and upload a file to the assignment for each
      3. Login as a teacher and go to the assignment grading page
      4. Change the filter on the grading table to "Needs grading"
      5. Enable quickgrading
      6. Enter a grade for the first student and click "Save all quick grading changes"
      7. Verify that you see a message "The grade changes were saved".
      8. Click continue
      9. Verify that the first student is no longer displayed in the grading table.
      10. Enter a grade for the second student and click "Save all quick grading changes"
      11. Click continue
      12. Verify that the second student is no longer displayed in the grading table.
      13. Change the grading filter back to "No filter".
      14. Verify that all previous changes to the grades for both students are reflected in the grading table.
      Show
      Create an assignment in a course with 2 or more students Set "Require students click submit button" to "No" File submissions to "Yes" Login as at least 2 students and upload a file to the assignment for each Login as a teacher and go to the assignment grading page Change the filter on the grading table to "Needs grading" Enable quickgrading Enter a grade for the first student and click "Save all quick grading changes" Verify that you see a message "The grade changes were saved". Click continue Verify that the first student is no longer displayed in the grading table. Enter a grade for the second student and click "Save all quick grading changes" Click continue Verify that the second student is no longer displayed in the grading table. Change the grading filter back to "No filter". Verify that all previous changes to the grades for both students are reflected in the grading table.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37646-master

      Description

      Quick grading won't save your grading changes if filter (e.g. Requires grading)applied. A page saying that your grading changes have not been saved because someone has changed the date appears instead.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Damyon Wiese added a comment -

            Thanks for reporting this issue - I will take a look at it ASAP.

            Show
            Damyon Wiese added a comment - Thanks for reporting this issue - I will take a look at it ASAP.
            Hide
            Damyon Wiese added a comment -

            Lowering the priority as it is not silently losing any data (You get shown an error).

            Show
            Damyon Wiese added a comment - Lowering the priority as it is not silently losing any data (You get shown an error).
            Hide
            Damyon Wiese added a comment -

            The problem was caused because the assignment was looking at a student who was not visible in the grading table and because they had no data submitted, was trying to set their grade/feedback back to empty - but it was then stopping because of the modified date check.

            Show
            Damyon Wiese added a comment - The problem was caused because the assignment was looking at a student who was not visible in the grading table and because they had no data submitted, was trying to set their grade/feedback back to empty - but it was then stopping because of the modified date check.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Integrated to master, 24 and 23.

            Thanks Damyon

            Show
            Dan Poltawski added a comment - Integrated to master, 24 and 23. Thanks Damyon
            Hide
            Andrew Davis added a comment -

            Works as described. Passing.

            Show
            Andrew Davis added a comment - Works as described. Passing.
            Hide
            Damyon Wiese added a comment -

            Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone!

            Regards, Damyon

            Show
            Damyon Wiese added a comment - Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone! Regards, Damyon

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: