Moodle
  1. Moodle
  2. MDL-37673

Invalid definition of the core/groupdata persistent cache

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Caching
    • Labels:
      None
    • Testing Instructions:
      Hide

      Testing difficulty: trivial

      1. Make sure the site is upgraded after the patch is applied (you may need to bump the version manually)
      2. Configure the site so that it displays MUC usage stats in the footer ("Caches interaction by definition then store")
      3. TEST: Make sure you can see the line "** static persist **" below the "core/groupdata" title.

      Show
      Testing difficulty: trivial 1. Make sure the site is upgraded after the patch is applied (you may need to bump the version manually) 2. Configure the site so that it displays MUC usage stats in the footer ("Caches interaction by definition then store") 3. TEST: Make sure you can see the line "** static persist **" below the "core/groupdata" title.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37673-muc-groupdata-typo
    • Rank:
      47378

      Description

      There is a trivial typo introduced by MDL-34398 in lib/db/caches.php that makes groupdata cache not being persistent.

      'persist' => true,
      

      should read

      'persistent' => true,
      

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          I'm on it.

          Show
          David Mudrak added a comment - I'm on it.
          Hide
          David Mudrak added a comment -

          Submitting for integration.

          Please note that the patch does not include the main version bump intentionally to make the integration easier.

          Show
          David Mudrak added a comment - Submitting for integration. Please note that the patch does not include the main version bump intentionally to make the integration easier.
          Hide
          Sam Hemelryk added a comment -

          Good catch thanks David!

          Show
          Sam Hemelryk added a comment - Good catch thanks David!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks David, has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks David, has been integrated now
          Hide
          Frédéric Massart added a comment -

          Tough test! Passed on master, thanks!

          Show
          Frédéric Massart added a comment - Tough test! Passed on master, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

          (and won't be revisiting it unless some regression is found)

          Thanks and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: