Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37674

no-header class for HTML blocks with no header

    Details

    • Testing Instructions:
      Hide
      1. Log in as an admin.
      2. Browse to a course.
      3. Inspect the navigation block and check that it doesn't have the "no-header" class.
      4. Turn on editing.
      5. Add an instance of the course summary block.
      6. Turn off editing.
      7. Inspect the course summary block and check it has the "no-header" class.
      Show
      Log in as an admin. Browse to a course. Inspect the navigation block and check that it doesn't have the "no-header" class. Turn on editing. Add an instance of the course summary block. Turn off editing. Inspect the course summary block and check it has the "no-header" class.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-37674-m26

      Description

      Depending on how you've styled your blocks, a block that has no header can lead to a missing top border on block content. It would be really nice if there were a class on the .block element that indicated that there was no header, so that if, for example, content then needs to be given a border-top and a border-radius on the two top corners, theme designers have a style with which to target those blocks.

      The .block_course_summary block has no header by default. Another block which can have no header, if a header title is not entered for it, is the HTML block.

      I am able to add a .no-header class to the .block_course_summary block with the patches above below, but am not able to get it working for the HTML block.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    18/Nov/13