Moodle
  1. Moodle
  2. MDL-37677

Debug info about obsolete string manager caches still displayed in the footer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Caching, Language
    • Labels:
      None
    • Testing Instructions:
      Hide

      Testing difficulty: the most trivial testing ever

      1. Make sure that performance debugging information is displayed in the footer of the site
      2. TEST: Make sure that the footer displays the number of get_string calls but it does not display "strings mem cache hits" and "strings disk cache hits" lines.

      Show
      Testing difficulty: the most trivial testing ever 1. Make sure that performance debugging information is displayed in the footer of the site 2. TEST: Make sure that the footer displays the number of get_string calls but it does not display "strings mem cache hits" and "strings disk cache hits" lines.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37677-obsolete-cache-debug
    • Rank:
      47382

      Description

      Now when MDL-34342 is integrated, the string manager uses MUC instead of previous internal caches. But the footer still displays debug info like

      strings mem cache hits: 0
      strings disk cache hits: 194 
      

      that is not valid any more.

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          I'm on it.

          Show
          David Mudrak added a comment - I'm on it.
          Hide
          David Mudrak added a comment -

          Submitting for integration.

          Show
          David Mudrak added a comment - Submitting for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks David, nice tidy up, has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks David, nice tidy up, has been integrated now.
          Hide
          Jason Fowler added a comment -

          If only all tests could be as easy as this. Thanks for fixing this David.

          Show
          Jason Fowler added a comment - If only all tests could be as easy as this. Thanks for fixing this David.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

          (and won't be revisiting it unless some regression is found)

          Thanks and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: