Moodle
  1. Moodle
  2. MDL-37686

XMLDB generated upgrade code gives warnings in codechecker.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Database SQL/XMLDB
    • Labels:
    • Testing Instructions:
      Hide
      1. Open the XMLDB Editor
      2. Generate each possible PHP code
        • Edit a file
          1. Click on 'View PHP code'
          2. For each element in the action dropdown menu: make sure no errors appear and the coding guidelines are respected
        • Click 'Back'
        • Select a table
          1. Click on 'View PHP code'
          2. For each element in the action dropdown menu: make sure no errors appear and the coding guidelines are respected
      Show
      Open the XMLDB Editor Generate each possible PHP code Edit a file Click on 'View PHP code' For each element in the action dropdown menu: make sure no errors appear and the coding guidelines are respected Click 'Back' Select a table Click on 'View PHP code' For each element in the action dropdown menu: make sure no errors appear and the coding guidelines are respected
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37686-master
    • Rank:
      47395

      Description

      Does not obey max line length or comment formatting (end in full stop).

        Activity

        Hide
        Petr Škoda added a comment -

        Thanks for the report.

        Show
        Petr Škoda added a comment - Thanks for the report.
        Hide
        Andrew Davis added a comment -

        [Y] Syntax
        [Y] Output
        [?] Whitespace
        [Y] Language
        [NA] Databases
        [?] Testing
        [NA] Security
        [NA] Documentation
        [Y] Git
        [Y] Sanity check

        From the testing instructions.
        "Make sure it works and the coding guidelines are respected"
        How would one go about doing that? I feel like you're missing a step here.

        You didn't introduce it but there is a space missing on line 522 of admin/tool/xmldb/actions/view_table_php/view_table_php.class.php
        $field->getName() . "', " .$field->getPHP(true)

        Otherwise looks good

        Show
        Andrew Davis added a comment - [Y] Syntax [Y] Output [?] Whitespace [Y] Language [NA] Databases [?] Testing [NA] Security [NA] Documentation [Y] Git [Y] Sanity check From the testing instructions. "Make sure it works and the coding guidelines are respected" How would one go about doing that? I feel like you're missing a step here. You didn't introduce it but there is a space missing on line 522 of admin/tool/xmldb/actions/view_table_php/view_table_php.class.php $field->getName() . "', " .$field->getPHP(true) Otherwise looks good
        Hide
        Frédéric Massart added a comment -

        Thanks Andrew, I've fixed the missing white space and edited my testing instructions. Cheers!

        Show
        Frédéric Massart added a comment - Thanks Andrew, I've fixed the missing white space and edited my testing instructions. Cheers!
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Cheers!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Cheers!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (master only), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
        Hide
        David Monllaó added a comment -

        It passes, the only no-PHP code I've found is a DON'T USE THIS FUNCTION (IT'S ONLY EXPERIMENTAL). SOME DBs DON'T SUPPORT IT! in table->rename_index and table->rename_key

        Show
        David Monllaó added a comment - It passes, the only no-PHP code I've found is a DON'T USE THIS FUNCTION (IT'S ONLY EXPERIMENTAL). SOME DBs DON'T SUPPORT IT! in table->rename_index and table->rename_key
        Hide
        Damyon Wiese added a comment -

        Congratulations this fix has been added to Moodle!

        You may want to dedicate this issue to someone special on this Valentines day.

        Thanks!

        Show
        Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: