Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37687

Comments paging seems broken for guests with renderer's $page passed to comment:init()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4, 2.5
    • Fix Version/s: 2.4.2
    • Component/s: Comments, Libraries
    • Labels:
    • Testing Instructions:
      Hide

      (pass in a renderer's $page property instead of nothing to commit::init() )
      1) create and display a plugin (or install local_plugins, ankit/marina has a working installation too) in the frontpage with a lot of comments on an entry so that it paginates.
      2) ensure that a non-logged-in-user can access the comments section of a plugin.
      3) access the plugin as a non-logged-in-user and see other comment pages as a non-logged-in-user only. (click on pages 2 onwards of the comments section)
      4) follow test instructions. pass this test.

      Show
      (pass in a renderer's $page property instead of nothing to commit::init() ) 1) create and display a plugin (or install local_plugins, ankit/marina has a working installation too) in the frontpage with a lot of comments on an entry so that it paginates. 2) ensure that a non-logged-in-user can access the comments section of a plugin. 3) access the plugin as a non-logged-in-user and see other comment pages as a non-logged-in-user only. (click on pages 2 onwards of the comments section) 4) follow test instructions. pass this test.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      37687_master_only_accesslib_fix

      Description

      1. With Chrome, go here https://moodle.org/plugins/view.php?plugin=theme_bootstrap
      2. Don't be logged in.
      3. Try to navigate to the second page of comments.

      Expected result: Comments area refreshes and shows second page.

      Actual result: "Unsupported redirect detected, script execution terminated"

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13