Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37697

Newly created forums course forums do not respect the user's HTML editor setting

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide
      • Set your 'When editing text' setting to 'Use HTML editor' in the 'Edit profile' page
      • Open a course
      • Turn editing on
      • Delete the News forum
      • Refresh the page
        • Confirm that the News forum was re-created
      • Open the mod_edit form for the forum
        • Confirm that the HTML editor is shown
      • Change your profile setting to 'Use standard web forms'
      • Delete the News forum
      • Refresh the page
        • Confirm that the News forum was re-created
      • Open the mod_edit form for the forum
        • Confirm that the HTML editor is not displayed
      Show
      Set your 'When editing text' setting to 'Use HTML editor' in the 'Edit profile' page Open a course Turn editing on Delete the News forum Refresh the page Confirm that the News forum was re-created Open the mod_edit form for the forum Confirm that the HTML editor is shown Change your profile setting to 'Use standard web forms' Delete the News forum Refresh the page Confirm that the News forum was re-created Open the mod_edit form for the forum Confirm that the HTML editor is not displayed
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      When the News forum is created in a new course, it is created with specifying the introformat, so it defaults to 0 (Moodle autoformat).

      We should probably respect a user's HTML editor settings when creating the forum.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            Will create branches for STABLE after peer review.

            Show
            dobedobedoh Andrew Nicols added a comment - Will create branches for STABLE after peer review.
            Hide
            andyjdavis Andrew Davis added a comment -

            [Y] Syntax
            [NA] Output
            [Y] Whitespace
            [NA] Language
            [NA] Databases
            [Y] Testing
            [NA] Security
            [NA] Documentation
            [?] Git
            [Y] Sanity check

            Is there a message for that commit? Otherwise this looks perfect. Submit for integration whenever you're ready.

            Show
            andyjdavis Andrew Davis added a comment - [Y] Syntax [NA] Output [Y] Whitespace [NA] Language [NA] Databases [Y] Testing [NA] Security [NA] Documentation [?] Git [Y] Sanity check Is there a message for that commit? Otherwise this looks perfect. Submit for integration whenever you're ready.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Confused... the commit message is already "MDL-37697 Use the correct editor format for course forums"

            Show
            dobedobedoh Andrew Nicols added a comment - Confused... the commit message is already " MDL-37697 Use the correct editor format for course forums"
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Andrew - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Andrew - this has been integrated now
            Hide
            phalacee Jason Fowler added a comment -

            Works as described Andrew, thanks for the patch!

            Show
            phalacee Jason Fowler added a comment - Works as described Andrew, thanks for the patch!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

            (and won't be revisiting it unless some regression is found)

            Thanks and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/13