Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37710

Students cannot access their own submitted files in a teamsubmission assignment

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.4.1
    • 2.4.2
    • Assignment
    • MOODLE_24_STABLE
    • MOODLE_24_STABLE
    • MDL-37710-master
    • Hide
      1. Create an assignment with these settings:
        1. "Students submit in groups" = "Yes"
        2. "File submissions" = "Yes"
        3. "Online text" = "Yes"
        4. "Submission comments" = "Yes"
      2. Login as a student and submit to the assignment. Make sure the submission includes:
        1. a file
        2. an image in the online text
      3. Verify you can download the file and see the image from the summary page of the assignment as a student.
      4. Add a comment to the submission and verify that it saves correctly.
      5. Login as a teacher and verify you can see the file and image and comments in the submission from the student.
      Show
      Create an assignment with these settings: "Students submit in groups" = "Yes" "File submissions" = "Yes" "Online text" = "Yes" "Submission comments" = "Yes" Login as a student and submit to the assignment. Make sure the submission includes: a file an image in the online text Verify you can download the file and see the image from the summary page of the assignment as a student. Add a comment to the submission and verify that it saves correctly. Login as a teacher and verify you can see the file and image and comments in the submission from the student.

    Description

      Assignment allows submission in team mode: one student submit a file and the file "counts" for all members of the group that worked as a team.

      Assignment correctly show the file link in the summary table for students and teachers. Teachers can click and get the submitted file without trouble. However, if the students try to access the submitted file they get an error message. Even the student that originally submitted the file.
      So, if one member of a team uploads a file, the other members cannot see the content. The students cannot verify that the uploaded file is the right one before clicking confirmation (if activated).

      The problem lies in teamsubmissions being stored in DB with userid=0. When assignsubmission_file_pluginfile() checks for permissions to see the submission associated file tries to test user with userid=0, that obviously do not exists.

      assignsubmission_file_pluginfile() must get groupid fron submission data, in addition to userid, and must check specifically for teamsumission and the check if current $USER asking to get the file is a member of the group indicated in the submission data.

      Attachments

        Issue Links

          Activity

            People

              damyon Damyon Wiese
              ecastro Enrique Castro
              Dan Poltawski Dan Poltawski
              Andrew Davis Andrew Davis
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Mar/13