Moodle

phpunit bootstrap does not create dataroot dir if missing

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.4, 2.4.1, 2.5
  • Fix Version/s: 2.3.5, 2.4.2
  • Component/s: Unit tests
  • Labels:
    None

Description

This is a regression caused by MDL-37555, the real_path() returns false if dir does not exist yet.

Issue Links

is a regression caused by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37555 Handle CFG->phpunit_dataroot like CFG->dataroot is

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Petr, this has been integrated now.

Show
Sam Hemelryk added a comment - Thanks Petr, this has been integrated now.
Hide
Permalink
Rossiani Wijaya added a comment -

This works as expected.

Tested for 2.3, 2.4 and master.

Test passed.

Show
Rossiani Wijaya added a comment - This works as expected. Tested for 2.3, 2.4 and master. Test passed.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

(and won't be revisiting it unless some regression is found)

Thanks and ciao

Show
Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: