Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37745

Control the display of available spaces in limited choices

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites:

      1. A course with a teacher and 3 students(S1..3) enrolled.

      Testing Instructions

      1. As teacher, insert a choice activity into you course with limits for the choices ("Limit the number of responses allowed" set to "Yes").
      2. Confirm you can see the "Show available spaces" checkbox and set it to "Yes".
      3. As student S1, go access the choice.
      4. Verify the "Responses" and "Limit" numbers are shown.
      5. Fill out a choice and submit.
      6. Login as S2 and go to the choice.
      7. Verify the "Responses" and "Limit" numbers are shown, with the "Responses" amount incremented by 1 based on choice in #5.
      8. As teacher, go access the choice.
      9. Follow the View 1 responses link in the upper right hand corner.
      10. Verify the limit numbers are shown in the 'Number of responses' row.
      11. As teacher, change the "Show available spaces" to "No".
      12. Log in as student S3, go access the choice.
      13. Verify the "Responses" and "Limit" numbers are not shown.
      14. Fill out a choice and submit.
      15. As teacher, go access the choice.
      16. Follow the View 2 responses link in the upper right hand corner.
      17. Verify the limit numbers are not shown in the 'Number of responses' row.

      (Note the option F not showing "Responses": and "Limit": is one which has Limit 0 that makes no sense anyway.)

      Show
      Prerequisites: A course with a teacher and 3 students(S1..3) enrolled. Testing Instructions As teacher, insert a choice activity into you course with limits for the choices ("Limit the number of responses allowed" set to "Yes"). Confirm you can see the "Show available spaces" checkbox and set it to "Yes". As student S1, go access the choice. Verify the "Responses" and "Limit" numbers are shown. Fill out a choice and submit. Login as S2 and go to the choice. Verify the "Responses" and "Limit" numbers are shown, with the "Responses" amount incremented by 1 based on choice in #5. As teacher, go access the choice. Follow the View 1 responses link in the upper right hand corner. Verify the limit numbers are shown in the 'Number of responses' row. As teacher, change the "Show available spaces" to "No". Log in as student S3, go access the choice. Verify the "Responses" and "Limit" numbers are not shown. Fill out a choice and submit. As teacher, go access the choice. Follow the View 2 responses link in the upper right hand corner. Verify the limit numbers are not shown in the 'Number of responses' row. (Note the option F not showing "Responses": and "Limit": is one which has Limit 0 that makes no sense anyway.)
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull Master Branch:
      MDL-37745-master

      Description

      The choice used to show the number of available spaces and the number of taken spaces to both the user answering the choice and in the table that displays the list of responses - it looks like some of this code is still there but has been orphaned due to the recent accessibility work and conversion to using renderers.

      The choice code should be tidied up and orphan code removed.

        Attachments

        1. 1Limit1.png
          1Limit1.png
          29 kB
        2. Choice limits.png
          Choice limits.png
          202 kB
        3. MDL-37745.png
          MDL-37745.png
          100 kB
        4. MDL-37745-after-1.png
          MDL-37745-after-1.png
          83 kB
        5. sample.patch
          1 kB

          Issue Links

            Activity

              People

              Assignee:
              lucaboesch Luca Bösch
              Reporter:
              danmarsden Dan Marsden
              Peer reviewer:
              Peter Dias Peter Dias
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 44 minutes
                  5h 44m