Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37746

normalizer_normalize is screwing up shortanswer questions for some people

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1. Run the unit tests.

      2. If you can work out how to trigger the PHP bug, then test that by previewing a short-answer question, but that does not seem to be possible.

      Show
      1. Run the unit tests. 2. If you can work out how to trigger the PHP bug, then test that by previewing a short-answer question, but that does not seem to be possible.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      The API is:

      Return Values: The normalized string or NULL if an error occurred.

      (See http://php.net/manual/en/normalizer.normalize.php and https://bugs.php.net/bug.php?id=64090)

      So, if something goes wrong, as it did in https://moodle.org/mod/forum/discuss.php?d=220722, then the input data gets eaten.

      The code needs to be changed to check for the NULL return value, and in that case output a debugging message, and the use the unmodified string.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13