Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37767

PostgreSQL and $CFG->dboptions['dbsocket'] = 1

    Details

      Description

      I've my main dev site with this setting:

      $CFG->dboptions['dbsocket'] = 1

      Under MySQL, it seems to work ok for normal use (web, cli, install, upgrade...) and phpunit passing 100%. Surely because I've the socket defined in php.ini (haven't tried without).

      But, under PostgreSQL, although it seems to work perfectly for normal use, it's failing badly when executing the phpunit tests. Apparently all the tests using adodb are failing / being skipped.

      I get this:

      ..S.........FSS..........S............ 1098 / 1632 ( 67%)
       
      There was 1 failure:
       
      1) enrol_database_testcase::test_sync_user_enrolments
      Failed asserting that 0 matches expected 2.
       
      Tests: 1630, Assertions: 29588, Failures: 1, Skipped: 5.
      

      Aka, 4 skipped and 1 failure 8not counting the "normal" ldap skip).

      It's dark-magic from where the postgres client gets the socket information, but it seems that there is one problem passing that option to adodb.

      Reproduced under master, haven't tried stables. Ciao

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            skodak Petr Skoda added a comment -

            Thanks for the report.

            Show
            skodak Petr Skoda added a comment - Thanks for the report.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (23, 24 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Passing with dbsocket = 1, yay!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Passing with dbsocket = 1, yay!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

            (and won't be revisiting it unless some regression is found)

            Thanks and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

              People

              • Assignee:
                skodak Petr Skoda
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Eloy Lafuente (stronk7)
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/13