Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37781

Workshop scheduled phase switching requires cron.php executed

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: easy

      The point of the testing is to make sure that the workshop switches from the submission phase into the assessment phase even without the cron.php being executed (make sure you do not run cron.php on the test site during this test).

      As usually when dealing with the Workshop testing, you may find http://docs.moodle.org/dev/Workshop/fakesubmissions.php useful.

      1. Prepare a simple workshop in a course with at least two participants.
      2. In the workshop setting, set the Submissions deadline to a near future (like T + 15 minutes or so). Also enable Switch to the next phase after the submissions deadline.
      3. Switch the workshop manually into the submission phase and let students submit their work.
      4. Enable the scheduled allocation and make sure its state is something like 'To be executed on {the submission deadline}

        '

      5. Go to the coffee machine and have a nice coffee or tea. Wander around the office for a while and have a friendly chat with your colleagues. Come back to the workshop after the configured submissions deadline.
      6. Visit the workshop main page (view.php)
      7. TEST: Make sure the workshop is now in the assessment phase.
      8. TEST: Make sure the submissions were allocated for the review as configured.
      9. TEST: Make sure the scheduled allocator's state is something like 'Executed on {the time when you displayed the view.php}

        '

      10. Wait a minute of two (hey, what about putting the coffee cup into the dishwasher meanwhile?)
      11. Switch the workshop into the submission phase manually and reload the view.php page.
      12. TEST: Make sure the workshop stays in the submission phase.

      Thanks for testing this!

      Show
      Testing difficulty: easy The point of the testing is to make sure that the workshop switches from the submission phase into the assessment phase even without the cron.php being executed (make sure you do not run cron.php on the test site during this test). As usually when dealing with the Workshop testing, you may find http://docs.moodle.org/dev/Workshop/fakesubmissions.php useful. Prepare a simple workshop in a course with at least two participants. In the workshop setting, set the Submissions deadline to a near future (like T + 15 minutes or so). Also enable Switch to the next phase after the submissions deadline . Switch the workshop manually into the submission phase and let students submit their work. Enable the scheduled allocation and make sure its state is something like 'To be executed on {the submission deadline} ' Go to the coffee machine and have a nice coffee or tea. Wander around the office for a while and have a friendly chat with your colleagues. Come back to the workshop after the configured submissions deadline. Visit the workshop main page (view.php) TEST: Make sure the workshop is now in the assessment phase. TEST: Make sure the submissions were allocated for the review as configured. TEST: Make sure the scheduled allocator's state is something like 'Executed on {the time when you displayed the view.php} ' Wait a minute of two (hey, what about putting the coffee cup into the dishwasher meanwhile?) Switch the workshop into the submission phase manually and reload the view.php page. TEST: Make sure the workshop stays in the submission phase. Thanks for testing this!
    • Workaround:
      Hide

      Say "Bah

      Show
      Say "Bah
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37781-workshop-schedule

      Description

      As discussed in MDL-26099: "There is a space for improvements, for sure. For example, the Workshop could check for the need of scheduled allocation every time when some user opens the workshop main page. For example, let us say the phase switching (and thence the allocation) is scheduled to 12:40 PM and the cron runs every 30 minutes. So the cron execution at 12:30 did not trigger anything yet, the next execution at 13:00 would do it. We could improve Workshop so that when some user (teacher, student or even a guest) looks at the workshop page at 12:43 PM, it would trigger the phase switch (so the result is what the user expects). Let me know if this would be suitable for your needs and we can open a new issue for that."

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  7 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13