Details
-
Type:
Task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.3.4, 2.4.1, 2.5
-
Component/s: Themes
-
Labels:
-
Testing Instructions:
- Go to privates files
- Switch to a RTL language
- Make sure the file picker opens nicely and looks good
- Test in different themes
-
Affected Branches:MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
-
Fixed Branches:MOODLE_23_STABLE, MOODLE_24_STABLE
-
Pull from Repository:
-
Pull 2.4 Branch:
MDL-37785_24 -
Pull 2.4 Diff URL:
-
Pull Master Branch:
MDL-37785_master -
Pull Master Diff URL:
-
Rank:47519
Description
Found while testing MDL-37645
The two CSS rules (see below) found in theme/base/style/core.css are also in theme/base/style/filemanager.css as they relate to the filemanager/file-picker. It follows then that these two rules can be safely deleted from core.css.
.dir-rtl .file-picker .yui-layout-unit-left {left:500px !important;}
.dir-rtl .file-picker .yui-layout-unit-center {left:0px !important;}
Activity
ALL BRANCHES REBASED 
Eh, you're a PRO already! Thanks!
PS: Edited, hehe, although you've a typo in the 24_STABLE branch name, lol. NP!
Integrated (23, 24 & master), thanks!
styke/core.css - LOL
Test seem to have passed, but I came up with my own testing instructions (I followed the linked issue but I don't think it's relevant). I'll be happy to test again if need be, but passing for now.
What you have done is great...thanks Fred
Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone!
Regards, Damyon
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao