Moodle

Remove duplicate .dir-rtl CSS rules from theme/base/style/core.css

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.4, 2.4.1, 2.5
  • Fix Version/s: 2.3.5, 2.4.2
  • Component/s: Themes
  • Labels:

Description

Found while testing MDL-37645

The two CSS rules (see below) found in theme/base/style/core.css are also in theme/base/style/filemanager.css as they relate to the filemanager/file-picker. It follows then that these two rules can be safely deleted from core.css.

.dir-rtl .file-picker .yui-layout-unit-left {left:500px !important;}
.dir-rtl .file-picker .yui-layout-unit-center {left:0px !important;}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Mary Evans added a comment -

ALL BRANCHES REBASED

Show
Mary Evans added a comment - ALL BRANCHES REBASED
Hide
Permalink
Eloy Lafuente (stronk7) added a comment - - edited

Eh, you're a PRO already! Thanks!

PS: Edited, hehe, although you've a typo in the 24_STABLE branch name, lol. NP!

Show
Eloy Lafuente (stronk7) added a comment - - edited Eh, you're a PRO already! Thanks! PS: Edited, hehe, although you've a typo in the 24_STABLE branch name, lol. NP!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated (23, 24 & master), thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
Hide
Permalink
Mary Evans added a comment -

styke/core.css - LOL

Show
Mary Evans added a comment - styke/core.css - LOL
Hide
Permalink
David Monllaó added a comment -

As there are no testing instructions and it was discovered while testing MDL-37645 I'd suggest to follow MDL-37645 testing instructions

Show
David Monllaó added a comment - As there are no testing instructions and it was discovered while testing MDL-37645 I'd suggest to follow MDL-37645 testing instructions
Hide
Permalink
Frédéric Massart added a comment -

Test seem to have passed, but I came up with my own testing instructions (I followed the linked issue but I don't think it's relevant). I'll be happy to test again if need be, but passing for now.

Show
Frédéric Massart added a comment - Test seem to have passed, but I came up with my own testing instructions (I followed the linked issue but I don't think it's relevant). I'll be happy to test again if need be, but passing for now.
Hide
Permalink
Mary Evans added a comment -

What you have done is great...thanks Fred

Show
Mary Evans added a comment - What you have done is great...thanks Fred
Hide
Permalink
Damyon Wiese added a comment -

Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone!

Regards, Damyon

Show
Damyon Wiese added a comment - Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone! Regards, Damyon

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: