Moodle
  1. Moodle
  2. MDL-37800

Feedback Module: "Information" does not appear anywhere

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.3.5, 2.4.2, 2.5
    • Component/s: Feedback
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Activate the feedback activity inside the activity administration page.
      2. Create a feedback instance inside some course.
      3. Choose the setting Record user names: User's name will be logged and shown with answers.
      4. Add three times the item "Information". One with the Information type "Responsetime" one with "Course" and one with "Course category".
      5. Complete this feedback with one or more user accounts.
      6. Go to the page "Analysis". There should be the right information from this item.
      7. Click on "Export to Excel" and open the Excel file. There should be the right information in it.
      8. Go to the page "Show responses" and have a look into the single responses. There should be the right information too.
      9. Create another feedback instance with the settings "Anonymous".
      10. Do the same steps like above.
      11. The information should be show the same but the Responsetime should be shown as 1.1.1970.
      Show
      Activate the feedback activity inside the activity administration page. Create a feedback instance inside some course. Choose the setting Record user names: User's name will be logged and shown with answers. Add three times the item "Information". One with the Information type "Responsetime" one with "Course" and one with "Course category". Complete this feedback with one or more user accounts. Go to the page "Analysis". There should be the right information from this item. Click on "Export to Excel" and open the Excel file. There should be the right information in it. Go to the page "Show responses" and have a look into the single responses. There should be the right information too. Create another feedback instance with the settings "Anonymous". Do the same steps like above. The information should be show the same but the Responsetime should be shown as 1.1.1970.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
    • Pull Master Branch:
      MDL-37800_master
    • Rank:
      47538

      Description

      If you use the element "Information" in a feedback, the information about the course and category appear correctly when the student is answering the questions. But they are neither shown in "Analysis" nor in "Show responses" or in the excel export. In excel, the corresponding field shows only the date of 01.01.1970.

      I think the information about course and it's category are only useful in an excel export. So what's about the possibility of adding these information to the header of every excel export file?

        Activity

        Hide
        Steffen Pegenau added a comment -
        Show
        Steffen Pegenau added a comment - Seems related to https://tracker.moodle.org/browse/MDL-24357
        Hide
        Andreas Grabs added a comment -

        Hi Steffen,
        thank you for reporting this!
        Andreas

        Show
        Andreas Grabs added a comment - Hi Steffen, thank you for reporting this! Andreas
        Hide
        Andreas Grabs added a comment -

        Hi,
        I've fixed this issue. I'm hoping that the test instructions are ok.
        Best regards
        Andreas

        Show
        Andreas Grabs added a comment - Hi, I've fixed this issue. I'm hoping that the test instructions are ok. Best regards Andreas
        Hide
        Dan Poltawski added a comment -

        Hi Andreas,

        One thing i'm a bit unsure about is the use of the optional_param in the code to get the course. We general try to avoid passing information around through the request globals like this. However, I see this is in use throughout the feedback code already.

        Show
        Dan Poltawski added a comment - Hi Andreas, One thing i'm a bit unsure about is the use of the optional_param in the code to get the course. We general try to avoid passing information around through the request globals like this. However, I see this is in use throughout the feedback code already.
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks!

        Show
        Dan Poltawski added a comment - Integrated, thanks!
        Hide
        Adrian Greeve added a comment -

        Tested on the 2.3, 2.4 and master integration branches.
        No problems found.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested on the 2.3, 2.4 and master integration branches. No problems found. Test passed.
        Hide
        Damyon Wiese added a comment -

        Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone!

        Regards, Damyon

        Show
        Damyon Wiese added a comment - Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone! Regards, Damyon

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: