Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37806

Workshop does not display "Save and show next" button

    Details

    • Testing Instructions:
      Hide

      Testing difficulty: easy

      1. Prepare a workshop with couple of participants and let students submit their work (you may want to use
        http://docs.moodle.org/dev/Workshop/fakesubmissions.php)
      2. Allocate submissions so that there is at least one reviewer that has three and more submissions assigned for assessment.
      3. Switch the workshop to the assessment phase
      4. Log in as that reviewer and assess the first submission
      5. TEST: Make sure there is a button 'Save and show next' displayed at the bottom of the assessment form and that it works.
      6. TEST: Use the button to assess remaining submissions. Make sure that when assessing the last submission, the button is not displayed any more (as there is no pending submission to assess).

      Thanks for your time spent on this!

      Show
      Testing difficulty: easy Prepare a workshop with couple of participants and let students submit their work (you may want to use http://docs.moodle.org/dev/Workshop/fakesubmissions.php ) Allocate submissions so that there is at least one reviewer that has three and more submissions assigned for assessment. Switch the workshop to the assessment phase Log in as that reviewer and assess the first submission TEST: Make sure there is a button 'Save and show next' displayed at the bottom of the assessment form and that it works. TEST: Use the button to assess remaining submissions. Make sure that when assessing the last submission, the button is not displayed any more (as there is no pending submission to assess). Thanks for your time spent on this!
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37806-workshop-next

      Description

      From the Twitter:

      Barbara Taylor (@bltmacomb) 3/08/12 12:14 PM
      @moodler please ask workshop developer to add a button
      that would bring up the next paper when students
      are evaluating - thanks #mootusca12
      

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            mudrd8mz David Mudrák added a comment -

            Submitting for integration. There is now a button 'Save and show next' displayed if there are some pending (that is not-graded-yet) submissions to assess. When assessing the last remaining submission, the button is not displayed any more.

            Thanks Barbara for this small yet useful usability improvement suggestion.

            Show
            mudrd8mz David Mudrák added a comment - Submitting for integration. There is now a button 'Save and show next' displayed if there are some pending (that is not-graded-yet) submissions to assess. When assessing the last remaining submission, the button is not displayed any more. Thanks Barbara for this small yet useful usability improvement suggestion.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks David - 2 suggestions for this feature (only suggestions though - you can decide if they make sense).

            1. This takes you to the next ungraded submission, so once the submissions are graded, there is no way to easily navigate through the submissions and reassess them - maybe it should just take you to the next submission regardless.

            2. There is no way to go directly to the next submission without grading the current submission - maybe there should be a "Next" button that does not save the current assessment. This is subjective though as it adds another button to the list of buttons so it might be better this way.

            These changes could both be done separately to this issue if you decide to do anything.

            Show
            damyon Damyon Wiese added a comment - Thanks David - 2 suggestions for this feature (only suggestions though - you can decide if they make sense). 1. This takes you to the next ungraded submission, so once the submissions are graded, there is no way to easily navigate through the submissions and reassess them - maybe it should just take you to the next submission regardless. 2. There is no way to go directly to the next submission without grading the current submission - maybe there should be a "Next" button that does not save the current assessment. This is subjective though as it adds another button to the list of buttons so it might be better this way. These changes could both be done separately to this issue if you decide to do anything.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks David,

            This is integrated now - but only for master. This is an improvement rather than a bug fix and we have tightened up our policies for backports.

            See:

            http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport

            If you still think we should backport this change.

            Cheers, Damyon

            Show
            damyon Damyon Wiese added a comment - Thanks David, This is integrated now - but only for master. This is an improvement rather than a bug fix and we have tightened up our policies for backports. See: http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport If you still think we should backport this change. Cheers, Damyon
            Hide
            mudrd8mz David Mudrák added a comment -

            Thanks Damyon for the review. I fully respect your classification this as an improvement rather that a bug fix.

            Also thanks for your suggestions. I have considered this as well. However, I was trying to avoid "over-buttonization" of the form. From what I know from real Workshop users out there, for most peer-reviewers (students) the common case is "to grade and done". Given that there is a way to jump to any assigned submission easily from the workshop main page, I finally decided for the implemented behaviour. I have no problem with adding yet another navigation button if there is a real community demand for it though, for sure.

            Show
            mudrd8mz David Mudrák added a comment - Thanks Damyon for the review. I fully respect your classification this as an improvement rather that a bug fix. Also thanks for your suggestions. I have considered this as well. However, I was trying to avoid "over-buttonization" of the form. From what I know from real Workshop users out there, for most peer-reviewers (students) the common case is "to grade and done". Given that there is a way to jump to any assigned submission easily from the workshop main page, I finally decided for the implemented behaviour. I have no problem with adding yet another navigation button if there is a real community demand for it though, for sure.
            Hide
            phalacee Jason Fowler added a comment -

            Works perfectly David, thanks for this

            Show
            phalacee Jason Fowler added a comment - Works perfectly David, thanks for this
            Hide
            damyon Damyon Wiese added a comment -

            Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone!

            Regards, Damyon

            Show
            damyon Damyon Wiese added a comment - Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone! Regards, Damyon
            Hide
            marycooch Mary Cooch added a comment -

            Removing qa_test_required label as there is a test for this now MDLQA-5259 ready for including in the next cycle.

            Show
            marycooch Mary Cooch added a comment - Removing qa_test_required label as there is a test for this now MDLQA-5259 ready for including in the next cycle.
            Hide
            marycooch Mary Cooch added a comment - - edited

            Removing docs_required label as I think this will be clear enough to those users who see it but it anyone disagrees please speak here or feel free to add to the docs.

            Show
            marycooch Mary Cooch added a comment - - edited Removing docs_required label as I think this will be clear enough to those users who see it but it anyone disagrees please speak here or feel free to add to the docs.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13