Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5, STABLE backlog
    • Component/s: Themes
    • Labels:
    • Rank:
      47570

      Description

      I've been working on MDL-35819 and have just come across a load of CSS relating to help text. It doesn't seem to be related to the work I'm doing, but equally it does seem orphaned.

      This is in theme/base/style/core.css:

      /**
       * Help
       */
      #help_icon_tooltip div.bd {width: 35em;}
      #help hr {border: none;height: 1px;background: #ccc;}
      #help .center {text-align: center;}
      #help .moreinfo {text-align: right;}
      #help .indent {margin-left: 40px;}
      #help .indent-big {margin-left: 160px;margin-right: 160px;}
      #help #emoticons{text-align: center;clear:both;width: 300px;margin-right: auto;margin-left:auto;}
      #help #emoticons ul{list-style-type: none;}
      #help #emoticons li{margin-bottom: 3px;width: 120px;border-left: 3px solid gray;padding-left: 7px;float: left;}
      

      The #help_icon_tooltip bit relates to some code removed in MDL-22067, but I haven't yet been able to work out where the #help section comes from.
      indent-big is not used in core, and nor is moreinfo.
      I also can't see anywhere which #emoticons is used.

        Issue Links

          Activity

          Hide
          Mary Evans added a comment -

          It's from this file in MOODLE_19_STABLE

          STARTS AT LINE 4280
          https://github.com/moodle/moodle/blob/MOODLE_19_STABLE/theme/standard/styles_layout.css

          Show
          Mary Evans added a comment - It's from this file in MOODLE_19_STABLE STARTS AT LINE 4280 https://github.com/moodle/moodle/blob/MOODLE_19_STABLE/theme/standard/styles_layout.css
          Hide
          Andrew Nicols added a comment -

          I guess that those can probably be removed entirely then. I really don't see anywhere that they're used any more.

          Show
          Andrew Nicols added a comment - I guess that those can probably be removed entirely then. I really don't see anywhere that they're used any more.
          Hide
          Mary Evans added a comment -

          I'll do these now before I forget!

          Show
          Mary Evans added a comment - I'll do these now before I forget!
          Hide
          Mary Evans added a comment -

          All done, in between doing a thousand other things!

          Show
          Mary Evans added a comment - All done, in between doing a thousand other things!
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Cheers!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Cheers!
          Hide
          Mary Evans added a comment -

          REBASED ALL BRANCHES

          Show
          Mary Evans added a comment - REBASED ALL BRANCHES
          Hide
          Damyon Wiese added a comment -

          Hi Mary,

          In line with our current backporting policy, this is an improvement so I've only pushed this to master.

          http://docs.moodle.org/dev/Integration_Review#Backporting

          Thanks, Damyon

          Show
          Damyon Wiese added a comment - Hi Mary, In line with our current backporting policy, this is an improvement so I've only pushed this to master. http://docs.moodle.org/dev/Integration_Review#Backporting Thanks, Damyon
          Hide
          Mark Nelson added a comment -

          I was able to successfully not test this. Passing.

          Show
          Mark Nelson added a comment - I was able to successfully not test this. Passing.
          Hide
          Damyon Wiese added a comment -

          Congratulations this fix has been added to Moodle!

          You may want to dedicate this issue to someone special on this Valentines day.

          Thanks!

          Show
          Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: