Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37838

My Moodle "You have 1 messages" is incorrectly pluralized

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. In a site with two users, send a message from user A to user B. Don't read the message as user B
      2. As admin, go to Site administration / ▶ Plugins / ▶ Blocks / ▶ Course overview
      3. Enable 'Show welcome area'
      4. As user B, go to moodle/my/ - verify you see the correct pluralisation of 'messages' when one message only.
      Show
      In a site with two users, send a message from user A to user B. Don't read the message as user B As admin, go to Site administration / ▶ Plugins / ▶ Blocks / ▶ Course overview Enable 'Show welcome area' As user B, go to moodle/my/ - verify you see the correct pluralisation of 'messages' when one message only.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37838-master
    • Pull Master Diff URL:

      Description

      There's a bug in block_course_overview's renderer, in the welcome_area function which means that it pluralises message incorrectly if you have exactly one message waiting.

        Attachments

          Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-12433 get_string support for plurals and some other grammar via simple conditional expressions

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              Eric Merrill Eric Merrill
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Jason Fowler Jason Fowler
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14