Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-37847~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-37847
Testing Instructions:

Hide

1. Create an essay question that uses Plain text Response format.
2. Preview the question, and input a response that includes HTML special characters. (See, for example https://moodle.org/mod/forum/discuss.php?d=220480#p963039.)
3. Sumbit all and finish. Verify that the response has been saved and re-displayed correctly.

4. Ideally verify the other three response format also still work.

Show
1. Create an essay question that uses Plain text Response format. 2. Preview the question, and input a response that includes HTML special characters. (See, for example https://moodle.org/mod/forum/discuss.php?d=220480#p963039 .) 3. Sumbit all and finish. Verify that the response has been saved and re-displayed correctly. 4. Ideally verify the other three response format also still work.

Steps to reproduce:

1. Create an essay question where the response format is 'Plain text', not 'HTML editor'.

2. Preview the question using deferred feedback, and enter a response like:

Here <is> some junk</is>:

x < 1

3. Submit all and finish.

Expected result:

The question is shown in review mode, with the student's answer clearly visible.

Actual result:

The review shows

Here some junk:

x < 1

Discovered while testing

MDL-37896 qtype essay uses the wrong PARAM type

MDL-38119 Document MDL-37847 question API change in upgrade.txt

MDL-37908 Clarify and review uses of PARAM_CLEANHTML

MDL-37909 Create common function for handling mod->name format

Participants:: Damyon Wiese, Eloy Lafuente (stronk7), Frédéric Massart, Justin Hunt, Petr Skoda, Tim Hunt