Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37864

New method to add help icons to the sortable table headers

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4, 3.0
    • Fix Version/s: 3.0
    • Component/s: Libraries
    • Testing Instructions:
      Hide
      1. download attached archive moodle-local_tabletest.zip
      2. unzip it in <your_moodle_directory>/local/
      3. open your browser and input address: <your_moodle_directory>/local/tabletest/
      4. click on each help icon in the table header
      5. make sure you see AJAX window with help icon's description, the page is not reloaded and the table is still there
      6. Click on each link on the sortable table. Make sure the sortable icon appears in the correct place and the help icon is still displayed
      7. Go to an existing table with help strings such as Site administration ► Plugins ► Blocks ► Manage blocks
      8. Make sure it displays correctly, with no errors.
      9. Click the help icon and ensure it appears as a popup
      10. Go to a course's Participants page
      11. Make sure the table displays correctly, with no errors.
      12. Click on a few of the titles and ensure each sorts on that column
      Show
      download attached archive moodle-local_tabletest.zip unzip it in <your_moodle_directory>/local/ open your browser and input address: <your_moodle_directory>/local/tabletest/ click on each help icon in the table header make sure you see AJAX window with help icon's description, the page is not reloaded and the table is still there Click on each link on the sortable table. Make sure the sortable icon appears in the correct place and the help icon is still displayed Go to an existing table with help strings such as Site administration ► Plugins ► Blocks ► Manage blocks Make sure it displays correctly, with no errors. Click the help icon and ensure it appears as a popup Go to a course's Participants page Make sure the table displays correctly, with no errors. Click on a few of the titles and ensure each sorts on that column
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37864-master

      Description

      I'm using Moodle Table API for creating table with sorting. Every sorting column has help icon. In moodle 2.3 all help icons displayed it's content, but in moodle 2.4 only non-sortable column show it's description - other icons works as simple link and opens empty page with help icon's description. It looks like a bug in Table API.

      How to reproduce:
      1) download attached archive "reproduce"
      2) unpack it in <your_moodle_directory>/local/
      3) open your browser and got to address: <your_moodle_site>/local/tabletest/test.php You will see simple table with sorting.
      4) click on help icon in the table header
      5) page reloaded to show just help, instead of using normal Moodle AJAX help mini-window without hiding the table

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15