[MDL-37872] Drop node: true option from jshintrc - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-37872~~-m
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/commit/MDL-37872-m
Testing Instructions:
Hide

Install node.js and then install jshint (npm install -g jshint).

Try passing a few files through jshint:

lib/yui/chooserdialogue/chooserdialogue.js

lib/yui/formautosubmit/formautosubmit.js

lib/yui/formchangechecker/formchangechecker.js

Open up the config and change the "strict" option to true

Rerun the tests

Confirm that some errors were shown this time

Try through some files we haven't yet cleaned up:

lib/yui/notification/notification.js
Show
Install node.js and then install jshint (npm install -g jshint). Try passing a few files through jshint: lib/yui/chooserdialogue/chooserdialogue.js lib/yui/formautosubmit/formautosubmit.js lib/yui/formchangechecker/formchangechecker.js Open up the config and change the "strict" option to true Rerun the tests Confirm that some errors were shown this time Try through some files we haven't yet cleaned up: lib/yui/notification/notification.js

As raised in IR for ~~MDL-37626~~

Testing discovered

MDL-37626 Include .jshintrc to moodle.git

Participants:: Adrian Greeve, Andrew Lyons, Damyon Wiese, Eloy Lafuente (stronk7), Frédéric Massart

Component watchers:: Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze