Moodle
  1. Moodle
  2. MDL-37872

Drop node: true option from jshintrc

        Details

        • Testing Instructions:
          Hide

          Install node.js and then install jshint (npm install -g jshint).

          • Try passing a few files through jshint:
            1. lib/yui/chooserdialogue/chooserdialogue.js
            2. lib/yui/formautosubmit/formautosubmit.js
            3. lib/yui/formchangechecker/formchangechecker.js
          • Open up the config and change the "strict" option to true
          • Rerun the tests
          • Confirm that some errors were shown this time
          • Try through some files we haven't yet cleaned up:
            1. lib/yui/notification/notification.js
          Show
          Install node.js and then install jshint (npm install -g jshint). Try passing a few files through jshint: lib/yui/chooserdialogue/chooserdialogue.js lib/yui/formautosubmit/formautosubmit.js lib/yui/formchangechecker/formchangechecker.js Open up the config and change the "strict" option to true Rerun the tests Confirm that some errors were shown this time Try through some files we haven't yet cleaned up: lib/yui/notification/notification.js
        • Affected Branches:
          MOODLE_25_STABLE
        • Fixed Branches:
          MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
        • Pull Master Diff URL:
        • Rank:
          47625

          Description

          As raised in IR for MDL-37626

            Issue Links

            discovered while testing

            Improvement - An enhancement to an existing Moodle feature. MDL-37626 Include .jshintrc to moodle.git

            • Minor - Minor loss of function where workaround is possible
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Frédéric Massart added a comment -

              I believe such a change has been discussed and approve. I am pushing for integration, but I think that the component in the commit message could have been core or javascript. Or am I wrong and we're using Ajax as soon as it involves Javascript?

              Show
              Frédéric Massart added a comment - I believe such a change has been discussed and approve. I am pushing for integration, but I think that the component in the commit message could have been core or javascript. Or am I wrong and we're using Ajax as soon as it involves Javascript?
              Hide
              Permalink
              Damyon Wiese added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              Thanks!

              Show
              Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Integrated (master only), thanks!

              Show
              Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
              Hide
              Permalink
              Adrian Greeve added a comment -

              Tested on the master integration branch.

              Everything worked as described.
              Test passed.

              Show
              Adrian Greeve added a comment - Tested on the master integration branch. Everything worked as described. Test passed.
              Hide
              Permalink
              Damyon Wiese added a comment -

              Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

              Regards, Damyon

              Show
              Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: