Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37872

Drop node: true option from jshintrc

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.5
          • Fix Version/s: 2.5
          • Component/s: JavaScript
          • Labels:
          • Testing Instructions:
            Hide

            Install node.js and then install jshint (npm install -g jshint).

            • Try passing a few files through jshint:
              1. lib/yui/chooserdialogue/chooserdialogue.js
              2. lib/yui/formautosubmit/formautosubmit.js
              3. lib/yui/formchangechecker/formchangechecker.js
            • Open up the config and change the "strict" option to true
            • Rerun the tests
            • Confirm that some errors were shown this time
            • Try through some files we haven't yet cleaned up:
              1. lib/yui/notification/notification.js
            Show
            Install node.js and then install jshint (npm install -g jshint). Try passing a few files through jshint: lib/yui/chooserdialogue/chooserdialogue.js lib/yui/formautosubmit/formautosubmit.js lib/yui/formchangechecker/formchangechecker.js Open up the config and change the "strict" option to true Rerun the tests Confirm that some errors were shown this time Try through some files we haven't yet cleaned up: lib/yui/notification/notification.js
          • Affected Branches:
            MOODLE_25_STABLE
          • Fixed Branches:
            MOODLE_25_STABLE
          • Pull from Repository:
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            As raised in IR for MDL-37626

              Gliffy Diagrams

                Attachments

                  Issue Links

                  Testing discovered

                  Improvement - An enhancement to an existing Moodle feature. MDL-37626 Include .jshintrc to moodle.git

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    fred Frédéric Massart added a comment -

                    I believe such a change has been discussed and approve. I am pushing for integration, but I think that the component in the commit message could have been core or javascript. Or am I wrong and we're using Ajax as soon as it involves Javascript?

                    Show
                    fred Frédéric Massart added a comment - I believe such a change has been discussed and approve. I am pushing for integration, but I think that the component in the commit message could have been core or javascript. Or am I wrong and we're using Ajax as soon as it involves Javascript?
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                    Thanks!

                    Show
                    damyon Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Integrated (master only), thanks!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    Tested on the master integration branch.

                    Everything worked as described.
                    Test passed.

                    Show
                    abgreeve Adrian Greeve added a comment - Tested on the master integration branch. Everything worked as described. Test passed.
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

                    Regards, Damyon

                    Show
                    damyon Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        4 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          14/May/13