Moodle
  1. Moodle
  2. MDL-37883

When importing assignment grades (offline marking) comma separated decimal grades are not handled correctly.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.4.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an assignment (mod_assign)
      2. Grade several students in the assignment - give them grades with a decimal component (e.g. 34.9)
      3. Change the language to French
      4. Download the offline grading worksheet (drop down menu above the grading table in the assignment).
      5. Open the exported CSV file
      6. Verify the format of the grades is using comma as a decimal separator
      7. Change only the decimal component of a grade (e.g. 34,9 -> 34,5)
      8. Upload the modified grading worksheet (drop down menu above the grading table in the assignment).
      9. Verify the student received the correct updated grade.
      Show
      Create an assignment (mod_assign) Grade several students in the assignment - give them grades with a decimal component (e.g. 34.9) Change the language to French Download the offline grading worksheet (drop down menu above the grading table in the assignment). Open the exported CSV file Verify the format of the grades is using comma as a decimal separator Change only the decimal component of a grade (e.g. 34,9 -> 34,5) Upload the modified grading worksheet (drop down menu above the grading table in the assignment). Verify the student received the correct updated grade.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
    • Pull Master Branch:
      MDL-37883-master
    • Rank:
      47636

      Description

      Check for proper use of unformat_float.

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          This feature only exists in 2.4 and 2.5.

          Show
          Damyon Wiese added a comment - This feature only exists in 2.4 and 2.5.
          Hide
          Damyon Wiese added a comment -

          There is a separate issue for creating unit tests for the offline marking.

          Show
          Damyon Wiese added a comment - There is a separate issue for creating unit tests for the offline marking.
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Cheers!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Cheers!
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks Damyon

          Show
          Dan Poltawski added a comment - Integrated, thanks Damyon
          Hide
          Jason Fowler added a comment -

          in both versions of moodle, a problem with rounding when exporting the CSV is encountered. Damyon said it had something to do with the float method he used.

          Show
          Jason Fowler added a comment - in both versions of moodle, a problem with rounding when exporting the CSV is encountered. Damyon said it had something to do with the float method he used.
          Hide
          Damyon Wiese added a comment -

          Just checked and this is in the current stables too. But - it makes sense to fix it here.

          Show
          Damyon Wiese added a comment - Just checked and this is in the current stables too. But - it makes sense to fix it here.
          Hide
          Damyon Wiese added a comment -

          Problem is that exported grades get rounded to 1 decimal place which means they look modified on the way back in.

          Show
          Damyon Wiese added a comment - Problem is that exported grades get rounded to 1 decimal place which means they look modified on the way back in.
          Hide
          Damyon Wiese added a comment -

          Rebased both branches and added one commit on each to fix this issue (can cherry pick or merge).

          Show
          Damyon Wiese added a comment - Rebased both branches and added one commit on each to fix this issue (can cherry pick or merge).
          Hide
          Dan Poltawski added a comment -

          Pulled that in. Back to testing, thanks

          Show
          Dan Poltawski added a comment - Pulled that in. Back to testing, thanks
          Hide
          Jason Fowler added a comment -

          All working now. Thanks Damyon.

          Show
          Jason Fowler added a comment - All working now. Thanks Damyon.
          Hide
          Damyon Wiese added a comment -

          Congratulations this fix has been added to Moodle!

          You may want to dedicate this issue to someone special on this Valentines day.

          Thanks!

          Show
          Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: