Moodle
  1. Moodle
  2. MDL-37896

qtype essay uses the wrong PARAM type

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1, 2.5
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide
      1. Edit your profile and set When editing text to Use standard web forms.
      2. Preview an essay question using Response format: HTML editor.
      3. Enter some HTML (see below) selecting one of the following format:
        • Moodle
        • Plain text
        • Markdown
      4. Click Save.
      5. Verify that your response is processed appropriately.
      6. Click Submit all and finish.
      7. Verify that your response is processed appropriately.

      Sample text to input:

      <p><b>To: John Doe</b> <johndoe@acme.com>
      <br/>From: Jane Doe <doe@xyz.com>
      <p>
      
      Show
      Edit your profile and set When editing text to Use standard web forms. Preview an essay question using Response format: HTML editor. Enter some HTML (see below) selecting one of the following format: Moodle Plain text Markdown Click Save. Verify that your response is processed appropriately. Click Submit all and finish. Verify that your response is processed appropriately. Sample text to input: <p><b>To: John Doe</b> <johndoe@acme.com> <br/>From: Jane Doe <doe@xyz.com> <p>
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
    • Pull Master Branch:
    • Rank:
      47650

      Description

      Discovered while testing MDL-37847.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Petr, does https://github.com/timhunt/moodle/compare/master...MDL-37896 look OK to you? particularly the change to the PHPdoc comment for PARAM_CLEANHTML.

          Show
          Tim Hunt added a comment - Petr, does https://github.com/timhunt/moodle/compare/master...MDL-37896 look OK to you? particularly the change to the PHPdoc comment for PARAM_CLEANHTML.
          Hide
          Petr Škoda added a comment -

          looks ok

          Show
          Petr Škoda added a comment - looks ok
          Hide
          Tim Hunt added a comment -

          Thanks Petr, submitting for integration.

          Show
          Tim Hunt added a comment - Thanks Petr, submitting for integration.
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Cheers!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Cheers!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23, 24 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
          Hide
          Andrew Davis added a comment -

          This seems to be working as described. Passing.

          Show
          Andrew Davis added a comment - This seems to be working as described. Passing.
          Hide
          Damyon Wiese added a comment -

          Congratulations this fix has been added to Moodle!

          You may want to dedicate this issue to someone special on this Valentines day.

          Thanks!

          Show
          Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: