Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37907

participants list checkbox location inconsistent with other user listings

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      While logged in as a normal teacher or admin user
      Enter a course that contains users - view the partipants list (link via people block)
      make sure the "brief" participants layout is being shown.
      check to make sure the checkboxes appear as the first column in the table
      probably a good idea to try some bulk actions to ensure it's working.

      check the detailed participants layout and make sure the checkbox is in the same location as previously - (see screenshots attached for examples)

      Show
      While logged in as a normal teacher or admin user Enter a course that contains users - view the partipants list (link via people block) make sure the "brief" participants layout is being shown. check to make sure the checkboxes appear as the first column in the table probably a good idea to try some bulk actions to ensure it's working. check the detailed participants layout and make sure the checkbox is in the same location as previously - (see screenshots attached for examples)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      master_MDL-37907

      Description

      the "brief" participants page layout places the checkbox as the last column of the table - most other reporting pages that list users in a table place the checkbox in the first column.

      This becomes a problem when the size of the middle column is small and in some themes (magazine is a good example) the checkbox is completely hidden unless using the scroll at the bottom of the table - but in using the scroll you can hide the users name and can't tell which user you're making the selection on.

      I think it makes sense to change the layout of the page to place the checkbox before the users name like on other report pages (quiz reports/assignment reports etc)

      I'm not sure about the "user details" view of the participants page - I think it makes sense to leave the checkbox in it's current location though.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            danmarsden Dan Marsden added a comment -

            adding Helen as she may have some ideas here - I'm guessing she might use the participants page a bit too?

            Dan - if there's general agreement that we should do something here, feel free to assign it back to me to do the work

            Show
            danmarsden Dan Marsden added a comment - adding Helen as she may have some ideas here - I'm guessing she might use the participants page a bit too? Dan - if there's general agreement that we should do something here, feel free to assign it back to me to do the work
            Hide
            tsala Helen Foster added a comment -

            Hi Dan, thanks for adding me as a watcher. I'm attaching screenshots showing the checkboxes on the participants page (also one where they are hidden) and on the quiz grades and assignment grading pages.

            Looking at the screenshots I would agree that it would be better for the checkboxes to appear next to the user pictures on the participants page with user list brief.

            For the participants page with user details, the checkboxes are not hidden so easily, so I would also agree with NOT moving these checkboxes.

            Show
            tsala Helen Foster added a comment - Hi Dan, thanks for adding me as a watcher. I'm attaching screenshots showing the checkboxes on the participants page (also one where they are hidden) and on the quiz grades and assignment grading pages. Looking at the screenshots I would agree that it would be better for the checkboxes to appear next to the user pictures on the participants page with user list brief. For the participants page with user details, the checkboxes are not hidden so easily, so I would also agree with NOT moving these checkboxes.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks for adding the screenshots Helen - that helps me see it and agree too!

            Show
            poltawski Dan Poltawski added a comment - Thanks for adding the screenshots Helen - that helps me see it and agree too!
            Hide
            poltawski Dan Poltawski added a comment -

            Do you think we need more consensus than us 3?

            Show
            poltawski Dan Poltawski added a comment - Do you think we need more consensus than us 3?
            Hide
            danmarsden Dan Marsden added a comment -
            Show
            danmarsden Dan Marsden added a comment - probably a good idea: https://moodle.org/mod/forum/discuss.php?d=221750
            Hide
            danmarsden Dan Marsden added a comment -

            couple of more votes - I've put some basic patches up for review - will let integrators decide if this should go into stable releases or just master.

            Show
            danmarsden Dan Marsden added a comment - couple of more votes - I've put some basic patches up for review - will let integrators decide if this should go into stable releases or just master.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Dan, changes look great thank you. Feel free to push this to integration when you are ready.

            In regards to back-porting as this is purely a visual change I am ever so slightly leaning towards master only.

            Many thanks
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Dan, changes look great thank you. Feel free to push this to integration when you are ready. In regards to back-porting as this is purely a visual change I am ever so slightly leaning towards master only. Many thanks Sam
            Hide
            danmarsden Dan Marsden added a comment -

            Thanks Sam - I think that makes sense - have updated master branch and removed others

            Show
            danmarsden Dan Marsden added a comment - Thanks Sam - I think that makes sense - have updated master branch and removed others
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (master only), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
            Hide
            andyjdavis Andrew Davis added a comment -

            Works as described. Passing.

            Show
            andyjdavis Andrew Davis added a comment - Works as described. Passing.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

            Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

            Thanks, closing as fixed!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!
            Hide
            marycooch Mary Cooch added a comment -

            Removing docs_required label as I'm not sure this needs documenting as it's a change that makes sense anyway -but if anyone disagrees, please speak or feel free to add to the docs.

            Show
            marycooch Mary Cooch added a comment - Removing docs_required label as I'm not sure this needs documenting as it's a change that makes sense anyway -but if anyone disagrees, please speak or feel free to add to the docs.

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13