Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37924

Quiz Admin settings defaults has sets 'fix'=true instead of 'adv'=true.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.7, 2.3.4, 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Quiz
    • Labels:
      None
    • Testing Instructions:
      Hide

      Make a fresh install of Moodle.

      Verify that, when you create a new quiz, about a dozen of the settings are 'Advanced'.

      Show
      Make a fresh install of Moodle. Verify that, when you create a new quiz, about a dozen of the settings are 'Advanced'.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:

      Description

      The format for advanced settings defaults was changed quite a while ago, but not all the quiz settings were updated correctly. The fix is to change 'fix' to 'adv' in mod/quiz/settings.php.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              timhunt Tim Hunt added a comment -

              Submitting for integration.

              Show
              timhunt Tim Hunt added a comment - Submitting for integration.
              Hide
              damyon Damyon Wiese added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              Cheers!

              Show
              damyon Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Cheers!
              Hide
              poltawski Dan Poltawski added a comment -

              Should I fix this in master? (Or you prefer for me to just wait for MDL-37786?)

              Show
              poltawski Dan Poltawski added a comment - Should I fix this in master? (Or you prefer for me to just wait for MDL-37786 ?)
              Hide
              damyon Damyon Wiese added a comment -

              I think we should fix this in master just for the history and I'll fix any conflicts in MDL-37786.

              Show
              damyon Damyon Wiese added a comment - I think we should fix this in master just for the history and I'll fix any conflicts in MDL-37786 .
              Hide
              poltawski Dan Poltawski added a comment -

              That was my thought too. Thanks.

              Integrated to master, 24 and 23.

              Show
              poltawski Dan Poltawski added a comment - That was my thought too. Thanks. Integrated to master, 24 and 23.
              Hide
              timhunt Tim Hunt added a comment -

              Well, since Damyon was happy to fix the merge conflicts in MDL-37786, master too is great. Why isn't MDL-37786 in integration yet?

              Show
              timhunt Tim Hunt added a comment - Well, since Damyon was happy to fix the merge conflicts in MDL-37786 , master too is great. Why isn't MDL-37786 in integration yet?
              Hide
              fred Frédéric Massart added a comment -

              Passed, thanks!

              Show
              fred Frédéric Massart added a comment - Passed, thanks!
              Hide
              damyon Damyon Wiese added a comment -

              Congratulations this fix has been added to Moodle!

              You may want to dedicate this issue to someone special on this Valentines day.

              Thanks!

              Show
              damyon Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13