Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37933

$criteria and $criterion should be swapped in completionlib.php:get_completions()

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5, 3.3.3, 3.4
    • Fix Version/s: 3.5
    • Component/s: Course completion
    • Labels:

      Description

      Sorry to be pedantic, but "criteria" is plural and "criterion" is singular, so "foreach ($criterion as $criteria)..." just reads strangely.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            usernamenumber Brad
            Peer reviewer:
            Shamim Rezaie
            Integrator:
            Damyon Wiese
            Tester:
            Damyon Wiese
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              17/May/18