Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37939

Moving modules between sections is not properly working

    Details

    • Testing Instructions:
      Hide

      On 2.3 only:

      Before applying upgrade:

      • take a course with a fair few CMs
      • check it's section data in the database using a query like:

        select id, section, sequence from mdl_course_sections where course = 5 order by section asc; select id, section from mdl_course_modules where course = 5;
        

      • move some course modules around. It's easiest to replicate if you have some CMs in the same section, and then move some of them out
      • check that they're broken - you should see duplicate cmids in the sections.sequence data, and no updates made to the modules.section data.
      • refresh the page and make some more changes: confirm that although the drag/drop appears to work, when you actually refresh the page it doesn't persist across a refresh
      • now apply the patch and perform the upgrade
      • confirm that the CMs didn't appear to move from where they were before the upgrade
      • confirm that the DB looks correct now (no duplicates in sequence data)
      • move some CMs around sections
      • refresh
        • confirm that the section sequence data is correct
        • confirm that the cm.section is correct

      On 2.4 and 2.5

      • take a course with a fair few CMs
      • apply the upgrade
      • confirm that the CMs didn't appear to move from where they were before the upgrade
      Show
      On 2.3 only: Before applying upgrade: take a course with a fair few CMs check it's section data in the database using a query like: select id, section, sequence from mdl_course_sections where course = 5 order by section asc; select id, section from mdl_course_modules where course = 5; move some course modules around. It's easiest to replicate if you have some CMs in the same section, and then move some of them out check that they're broken - you should see duplicate cmids in the sections.sequence data, and no updates made to the modules.section data. refresh the page and make some more changes: confirm that although the drag/drop appears to work, when you actually refresh the page it doesn't persist across a refresh now apply the patch and perform the upgrade confirm that the CMs didn't appear to move from where they were before the upgrade confirm that the DB looks correct now (no duplicates in sequence data) move some CMs around sections refresh confirm that the section sequence data is correct confirm that the cm.section is correct On 2.4 and 2.5 take a course with a fair few CMs apply the upgrade confirm that the CMs didn't appear to move from where they were before the upgrade
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      When moving modules between sections in Moodle 2.3.4+, section sequence data and course_module section data gets out of skew. As a result modules can be moved once but then it becomes impossible to move them again.

      When drag and drop moving is used, they will appear to move, but refreshing the page shows that they do not move.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  8 Vote for this issue
                  Watchers:
                  25 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13