Moodle
  1. Moodle
  2. MDL-37952

Declare grade_base_testcase abstract

    Details

    • Testing Instructions:
      Hide

      Run phpunit tests for all the target branches, they should continue ending without problems (especially any related to grade_base_testcase). Surely CI servers will do that for you.

      Show
      Run phpunit tests for all the target branches, they should continue ending without problems (especially any related to grade_base_testcase). Surely CI servers will do that for you.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      This comes from MDLSITE-2096 / MDL-37655, where we are detecting / fixing phpunit test files containing <> 1 test unit classes.

      When looking for "helper/base" classes being extended, it was found that all them are declared as abstract, but the grade_base_testcase that is missing that bit.

      For future detection and consistency, this is, simply, about to declare it as abstract too.

      Ciao

        Gliffy Diagrams

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sending straight to integration, trivial enough.

          Show
          Eloy Lafuente (stronk7) added a comment - Sending straight to integration, trivial enough.
          Hide
          Dan Poltawski added a comment -

          I might regard this as an improvement, and master only.

          I got one other integrators vote (Eloy) and seemed we could not reach a decision. In order to resolve this situation, I decided to challenge Eloy to a duel, we fought in armour and I lost to Eloy.

          Therefore, backporting to stable branches too.

          Show
          Dan Poltawski added a comment - I might regard this as an improvement, and master only. I got one other integrators vote (Eloy) and seemed we could not reach a decision. In order to resolve this situation, I decided to challenge Eloy to a duel, we fought in armour and I lost to Eloy. Therefore, backporting to stable branches too.
          Hide
          Dan Poltawski added a comment -

          Integrated to master, 24 and 23. Thanks.

          Show
          Dan Poltawski added a comment - Integrated to master, 24 and 23. Thanks.
          Hide
          David Monllaó added a comment -

          Passing as tests are running on the CI servers

          Show
          David Monllaó added a comment - Passing as tests are running on the CI servers
          Hide
          Damyon Wiese added a comment -

          Congratulations this fix has been added to Moodle!

          You may want to dedicate this issue to someone special on this Valentines day.

          Thanks!

          Show
          Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: