Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37952

Declare grade_base_testcase abstract

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Run phpunit tests for all the target branches, they should continue ending without problems (especially any related to grade_base_testcase). Surely CI servers will do that for you.

      Show
      Run phpunit tests for all the target branches, they should continue ending without problems (especially any related to grade_base_testcase). Surely CI servers will do that for you.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      This comes from MDLSITE-2096 / MDL-37655, where we are detecting / fixing phpunit test files containing <> 1 test unit classes.

      When looking for "helper/base" classes being extended, it was found that all them are declared as abstract, but the grade_base_testcase that is missing that bit.

      For future detection and consistency, this is, simply, about to declare it as abstract too.

      Ciao

        Attachments

          Activity

            People

            • Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Integrator:
              Dan Poltawski
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta, Ryan Wyllie, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/13